Bug 367619

Summary:	icon kcm: remove advanced tab
Product:	[Applications] systemsettings	Reporter:	andreas <kainz.a>
Component:	kcm_icons	Assignee:	Plasma Development Mailing List <plasma-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	olivier, unassigned-bugs
Priority:	NOR	Flags:	kainz.a: Usability+
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Other
Latest Commit:	https://commits.kde.org/plasma-desktop/9496728fcb6c012cf1deb773a3d0a5129b4a629e	Version Fixed In:	5.13.0
Sentry Crash Report:

Description andreas 2016-08-20 21:01:33 UTC

with the advanced tab in the icon kcm you can change the default size of icons and how the hover effect, ... should look like.

The problem is, that more than 50% of the functionality didn't work.

e.g. at toolbar you can't change the default height, at main tollbar and small icons it will change.

In general it would be very nice to change the height of the default toolbar icons but do the user really edit the hover effect. The color of icons were now changed by the color kcm, ...

don't ship broken stuff. so fix it or remove it.

Reproducible: Always

Comment 1 andreas 2016-08-28 14:36:06 UTC

Icon Theme KCM

In the Advanced Tab there are a lot of stuff that worked in the past but not with plasma 5.

Use of Icon

- Desktop
  Size didn't work. The user can switch in Desktop Settings to Folder View and see icons on the desktop, but the size from the kcm wasn't used. you can change the icon size with right click.
  The animation Stuff is nice and added in kde 3.x but I'm not sure if it would work and which file format.
  -> Desktop Section can be removed
  
- Toolbar
  didn't change the toolbar
  -> remove
  
- Main Toolbar
  work and is usefull, cause you can change the toolbar icon size for all kde applications
  
- Small Icons
  work partly. I'm not sure if it is usefull. there is also this scaling stuff (for hidpi) and the text height. maybe it would be more usefull to have it there. In general it didn't work 100% 
  -> remove it
  
- Panel
  change anything in a panel. not in the config panel or any other panel
  -> remove it broken
  
- Dialogs
  didn't work
  -> remove it

- All Icons
  You can change the color stuff for all icons. Funny thing, not realy usefull but funny.

- Collor stuff
  work now only for all icons. would maybe usefull for toolbar icons (monochrome ones) but I'm not sure cause the color stuff was changed now via the color scheme. this would be the better way to change color stuff.
  -> available via a color effect button.

Comment 2 andreas 2016-08-28 14:37:48 UTC

So after the review there is the color effect which is funny but not really usefull for the default user so I would hide the color stuff behind a button.

the global toolbar icon size is a really useful function I would ass to the main tab instead of hide behind the advanced tab.

Comment 3 Kai Uwe Broulik 2018-04-27 14:32:09 UTC

Git commit 9496728fcb6c012cf1deb773a3d0a5129b4a629e by Kai Uwe Broulik.
Committed on 27/04/2018 at 14:28.
Pushed by broulik into branch 'master'.

[Icon KCM] Port to new design

This completely drops the icon customization with icon effects and only retains the icon size settings.
Should there be any custom icon effects, pressing "Defaults" in the KCM will remove them.
I also couldn't find any trace of that "animations enabled" check box it used to have.
It adds drag and drop support for installing archives as themes. It can also download them from remote location
when dropped from e.g. a browser.

Installing theme files actually never worked in Plasma 5 as it got broken in the port from KIO NetAccess
to storedGet.
An animated preview is also added on hover showing a common selection of icons.

Implements T7262
Related: bug 334301, bug 163992
FIXED-IN: 5.13.0

Differential Revision: https://phabricator.kde.org/D12459

M  +8    -14   kcms/icons/CMakeLists.txt
M  +1    -1    kcms/icons/Messages.sh
D  +0    -716  kcms/icons/icons.cpp
D  +0    -147  kcms/icons/icons.h
A  +205  -0    kcms/icons/iconsmodel.cpp     [License: GPL (v2+)]
A  +84   -0    kcms/icons/iconsmodel.h     [License: GPL (v2+)]
D  +0    -491  kcms/icons/iconthemes.cpp
D  +0    -74   kcms/icons/iconthemes.h
R  +0    -0    kcms/icons/kcm_icons.desktop [from: kcms/icons/icons.desktop - 100% similarity]
M  +493  -48   kcms/icons/main.cpp
M  +75   -18   kcms/icons/main.h
A  +169  -0    kcms/icons/package/contents/ui/IconSizePopup.qml     [License: GPL (v2/3)]
A  +276  -0    kcms/icons/package/contents/ui/main.qml     [License: GPL (v2/3)]
A  +16   -0    kcms/icons/package/metadata.desktop
D  +0    -16   kcms/icons/tests/CMakeLists.txt
D  +0    -16   kcms/icons/tests/testicons.cpp

https://commits.kde.org/plasma-desktop/9496728fcb6c012cf1deb773a3d0a5129b4a629e