Bug 367585

Summary:	digital clock plasmoid scales with the panel indefinitely and wastes space
Product:	[Plasma] plasmashell	Reporter:	Thomas Weissel <xapient>
Component:	Digital Clock	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	subdiff
Priority:	NOR
Version:	5.7.2
Target Milestone:	1.0
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/1d362c4ae2e264a80c002ab6718c1b1d9437c20c	Version Fixed In:
Sentry Crash Report:
Attachments:	side panel with very large clock

Description Thomas Weissel 2016-08-19 19:16:59 UTC

the digital clock becomes ridiculously huge if you scale the width of a vertical panel to more than 128px 

it wastes to much space and while it makes sense to have such a broad panel for the taskmanager (so it can display program names) it makes absolutely no sense to have the clock covering a third of the panel...  

Reproducible: Always

Steps to Reproduce:
1.move the default panel to the left side of the screen (vertical panel)
2.stretch the panel width to more than 128 px 


Actual Results:  
the clock gets bigger and bigger until it covers all of the panel

Expected Results:  
the clock should have a fixed maximum width and height and spacing to the other plasmoids and NOT waste all of the available space

Comment 1 Thomas Weissel 2016-08-19 19:18:31 UTC

Created attachment 100686 [details]
side panel with very large clock

Comment 2 Roman Gilg 2016-12-25 17:04:26 UTC

I implemented a max value for font height in the latest diff of https://phabricator.kde.org/D3630

Check it out.

Comment 3 Roman Gilg 2017-01-03 14:48:13 UTC

Git commit 1d362c4ae2e264a80c002ab6718c1b1d9437c20c by Roman Gilg.
Committed on 03/01/2017 at 14:37.
Pushed by romangilg into branch 'master'.

[Digital Clock] Bug fixes and ui code optimization

Summary:
- Fixed timezone size and alignment in vertical mode
- Instead of `Flow` use `Grid` for labels as it's simpler and gives better
  control over alignment
- Seperator in small horizontal mode centered between date and time and in
  height now dependent on label size
- Less empty space around time in small horizontal mode
- Binding loop and initlializting anchor errors fixed
- Elements now size completely down and have always the same ratio to each other
  with the time label being the largest
- Round functions removed since they disrupted the resizing for small sizes
- Introduce max font size values for text elements in panel mode
Related: bug 360059, bug 373396

Reviewers: #plasma, mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3630

M  +206  -148  applets/digital-clock/package/contents/ui/DigitalClock.qml

https://commits.kde.org/plasma-workspace/1d362c4ae2e264a80c002ab6718c1b1d9437c20c