| Summary: | createReadWriteLock and createMetadataProcessor should not be pure virtual | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Johannes Zarl-Zierl <johannes> |
| Component: | Albums-Plugins | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/libkipi/860f11a91c9398397246bf554e24ff9b8b3adc6d | Version Fixed In: | 5.1.0 |
| Attachments: | Make createReadWriteLock and createMetadataProcessor not-pure. | ||
Git commit 860f11a91c9398397246bf554e24ff9b8b3adc6d by Maik Qualmann. Committed on 03/08/2016 at 16:35. Pushed by mqualmann into branch 'master'. apply patch #100422 to make implemented methods not pure virtual FIXED-IN: 5.1.0 M +2 -2 src/interface.h http://commits.kde.org/libkipi/860f11a91c9398397246bf554e24ff9b8b3adc6d Git commit 593cf8bf10349ce459fdf26c800f9b5b3301a4b3 by Gilles Caulier. Committed on 04/08/2016 at 09:36. Pushed by cgilles into branch 'master'. fix ABI/API ID since pure virtual method fingerprints have changed. M +3 -2 CMakeLists.txt http://commits.kde.org/libkipi/593cf8bf10349ce459fdf26c800f9b5b3301a4b3 |
Created attachment 100422 [details] Make createReadWriteLock and createMetadataProcessor not-pure. If an application does not implement the features HostSupportsReadWriteLock and HostSupportsMetadataProcessing, the current API still expects the host application to provide the functions createReadWriteLock and createMetadataProcessor. Both methods are already implemented in interface.cpp, so it seems to me that making them pure virtual was actually a mistake...