Bug 366030

Summary:	Ratio sensor seems to be applied after rotation under some conditions
Product:	[Applications] krita	Reporter:	Ilya V. Portnov <portnov>
Component:	Brush engines	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Debian unstable
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Here you can see some parallelograms where rectangles are expected to be seen Brush preset which was used for test

Description Ilya V. Portnov 2016-07-24 08:51:47 UTC

For test, i'm using simple brush with "predefined" brush tip, which is just filled square.
The preset is defined so that:
* rotation depends on drawing angle
* ratio depends on "fuzzy stroke".

I think that rotation should be applied after ratio; so, if you take a square, then apply "ratio" = 0.5, then rotate it, you will get a rotated rectangle. 
But if you first rotate the square, and next apply ratio, you will get a parallelogram. I think this is not what intended.

Will attach a screenshot.

Reproducible: Always


Actual Results:  
brush draws series of parallelograms.

Expected Results:  
brush draws series of rotated rectangles.

Comment 1 Ilya V. Portnov 2016-07-24 08:52:43 UTC

Created attachment 100264 [details]
Here you can see some parallelograms where rectangles are expected to be seen

Comment 2 Ilya V. Portnov 2016-07-24 08:53:37 UTC

Created attachment 100265 [details]
Brush preset which was used for test

Comment 3 Halla Rempt 2016-08-12 11:41:06 UTC

I've asked Nishanth to take a look.

Comment 4 Halla Rempt 2016-08-17 08:19:11 UTC

Fixed in 61c422b9ad25cb6291a9a33094331de4b0f9f7c2