| Summary: | Main menu bar is not translated (localized) | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Lukas Sommer <sommerluk> |
| Component: | Usability-i18n | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arojas, caulier.gilles, philippe.quaglia, sommerluk |
| Priority: | NOR | ||
| Version: | 5.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | http://commits.kde.org/digikam/6119e94222d0e88312c1ea08828b634d7c394e0e | Version Fixed In: | 5.5.0 |
| Sentry Crash Report: | |||
| Attachments: | screenshot.1.png | ||
|
Description
Lukas Sommer
2016-07-23 11:03:22 UTC
Created attachment 100260 [details]
screenshot.1.png
*** Bug 365694 has been marked as a duplicate of this bug. *** Git commit 6119e94222d0e88312c1ea08828b634d7c394e0e by Maik Qualmann. Committed on 24/07/2016 at 10:42. Pushed by mqualmann into branch 'master'. fix untranslated menu items FIXED-IN: 5.1.0 M +2 -1 NEWS M +1 -1 app/main/digikamui.rc M +1 -1 imageplugins/color/digikamimageplugin_color_ui.rc M +1 -1 imageplugins/decorate/digikamimageplugin_decorate_ui.rc M +1 -1 imageplugins/enhance/digikamimageplugin_enhance_ui.rc M +1 -1 imageplugins/filters/digikamimageplugin_fxfilters_ui.rc M +1 -1 imageplugins/transform/digikamimageplugin_transform_ui.rc M +1 -1 showfoto/main/showfotoui.rc M +1 -1 utilities/imageeditor/main/digikamimagewindowui.rc M +2 -2 utilities/importui/main/importui.rc M +1 -1 utilities/lighttable/lighttablewindowui.rc M +2 -2 utilities/queuemanager/main/queuemgrwindowui.rc http://commits.kde.org/digikam/6119e94222d0e88312c1ea08828b634d7c394e0e Maik, Do you see this patch too ? https://git.reviewboard.kde.org/r/128512/diff/1/ Gilles Git commit f4c5e15d8619d2cb41a841b646e8d95a63f80350 by Maik Qualmann. Committed on 24/07/2016 at 16:55. Pushed by mqualmann into branch 'master'. apply Patch from Burkhard Lueck to remove double setApplicationDomain() call M +0 -1 app/main/main.cpp http://commits.kde.org/digikam/f4c5e15d8619d2cb41a841b646e8d95a63f80350 still happens in 5.1.0 This is a different problem. 5.1.0-01 Windows installers miss all i18n files. Fixed in 5.1.0-02 installer just published. Gilles Caulier This is on Linux, not Windows. Everything is translated except for the menu bar, tested with different languages. *** Bug 369235 has been marked as a duplicate of this bug. *** Reopening, this is not fixed as of 5.2 The problem is that, for some reason, the system digikamui.rc doesn't override the local one, even though it has a higher version number (514 v. 505). So if the user has a digikamrc.ui from 5.0 this won't be fixed on upgrade without manually removing the local digikamui.rc What's about this file using digiKam AppImage bundle 5.4.0 pre release given at this url : https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM Gilles Caulier not a 5.4.0 windows installer is available in same repository for testing... Any feedback with 5.4.0 pre release installer for Windows available here : https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM Git commit 9057447deee97a4ce5ee609251d3439ac2a1c583 by Gilles Caulier. Committed on 09/01/2017 at 11:07. Pushed by cgilles into branch 'master'. there is definitively a problem with older ui.rc file from DK4 when we migrate to DK5, as some items from main menu are not show (but action still avaialble through keyboard shortcut). renaming ui.rc fix the problem M +1 -1 app/main/digikamapp.cpp R +1 -1 app/main/digikamui5.rc [from: app/main/digikamui.rc - 099% similarity] https://commits.kde.org/digikam/9057447deee97a4ce5ee609251d3439ac2a1c583 Git commit 20941e8744c3424efbc3e5c8604ecae772dd4f6f by Gilles Caulier. Committed on 09/01/2017 at 11:24. Pushed by cgilles into branch 'master'. there is definitively a problem with older ui.rc file from DK4 when we migrate to DK5, as some items from main menu are not show (but action still avaialble through keyboard shortcut). renaming ui.rc fix the problem M +1 -1 utilities/importui/CMakeLists.txt R +1 -1 utilities/importui/main/importui5.rc [from: utilities/importui/main/importui.rc - 098% similarity] M +1 -1 utilities/lighttable/CMakeLists.txt M +1 -1 utilities/lighttable/lighttablewindow.cpp R +1 -1 utilities/lighttable/lighttablewindowui5.rc [from: utilities/lighttable/lighttablewindowui.rc - 098% similarity] M +1 -1 utilities/queuemanager/CMakeLists.txt R +1 -1 utilities/queuemanager/main/queuemgrwindowui5.rc [from: utilities/queuemanager/main/queuemgrwindowui.rc - 097% similarity] https://commits.kde.org/digikam/20941e8744c3424efbc3e5c8604ecae772dd4f6f Git commit fe695c6b038a3ac6311cafc646f044c5bd5fb084 by Gilles Caulier. Committed on 09/01/2017 at 19:03. Pushed by cgilles into branch 'master'. fix target rc file names with '5' as prefix while migration from DK4 to DK5 M +3 -4 utilities/assistants/firstrun/migratefromdigikam4page.cpp M +2 -2 utilities/assistants/firstrun/migratefromdigikam4page.h https://commits.kde.org/digikam/fe695c6b038a3ac6311cafc646f044c5bd5fb084 I'm able to reproduce the problem while migrating DK4 to DK5 with French language. Renaming all RC files with '5' prefix fix the problem here. Warning : migrating old settings still problematic, and i don't know why. sound like a dysfunction in KDE API, but not sure. It's always better to start DK5 with a fresh settings, as it's explained in First-Run assistant. I close this file now. Don't hesistate to re-open if necessary. Gilles Caulier |