| Summary: | Systray icons are big and pixelated after update to 5.7.1 | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Heiko Becker <heiko.becker> |
| Component: | System Tray | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bartos.petr, bastian.beischer, bob.mt.wya, eherenz, elvis.angelaccio, kde, kde, kde, kikadf.01, luca86, luigi.toscano, mike, n.schnelle, nickbryda, pavel-verteletskiy, rdieter, tesfabpel, vasyl.demin, xavier.corredor.llano |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.7.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Exherbo | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 5.7.2 | |
| Sentry Crash Report: | |||
| Attachments: |
screenshot of the systray icons
Huge systray icons, no padding Comparison with other elements of the panel huge systray icons 5.7.1 Terrible huge systray icons Refactored: John Salatas's plasma-workspace-5.7.0-systray_iconsize.patch Refactored for Plasma 5.7.2: John Salatas's plasma-workspace-5.7.0-systray_iconsize.patch |
||
|
Description
Heiko Becker
2016-07-12 21:52:04 UTC
Created attachment 100046 [details]
screenshot of the systray icons
I also have huge icons with no padding around them (see attached screenshot, compare it to the Reshift Control widget to the left or the clock to the right) since 5.7.1. I assume this is a regression introduced by the fix for issue #364431. Created attachment 100049 [details]
Huge systray icons, no padding
(In reply to Janek Bevendorff from comment #2) > I also have huge icons with no padding around them (see attached screenshot, > compare it to the Reshift Control widget to the left or the clock to the > right) since 5.7.1. I assume this is a regression introduced by the fix for > issue #364431. Indeed. If I revert 1ba0e6e5ddd598e9b0cf87a654467f97c06b26c5 (or just edit /usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/main.qml) systray icons return to an appropriate size. I also discovered https://git.reviewboard.kde.org/r/128400/ which would make the size configurable (only targeted at master though). Created attachment 100055 [details]
Comparison with other elements of the panel
Created attachment 100083 [details]
huge systray icons 5.7.1
Created attachment 100089 [details]
Terrible huge systray icons
Also seeing this on 1080p https://bugs.kde.org/show_bug.cgi?id=364431#c13 (my comment with screenshot from the original bug) This problem should be fixed with this commit: https://quickgit.kde.org/?p=plasma-workspace.git&a=commitdiff&h=7f060403a2d44fc76b2b14fc9ebf43ee272d1c54 Please test it Created attachment 100134 [details] Refactored: John Salatas's plasma-workspace-5.7.0-systray_iconsize.patch I don't see how watering down John Salatas's original patch into a secret/ hidden setting - so basically it fixes nothing - achieves anything?? Last time I checked Plasma isn't going after the i3 DE market!! I remember requesting this feature back in 2014 (!!) on the VDG forums - I was not alone... https://forum.kde.org/viewtopic.php?f=285&t=121695 If user requests for features are to be ignored... What was the point of the VDG?? I've finally got the feature I wanted - thanks to John Salatas... But not really - because I've got to refactor this patch - every plasma-workspace release now... :-( Just to add Vertical side panels are still broken - by default - with no "user visible" switch to fix them. I can confirm this bug. Happened when updating from 5.7.0 to 5.7.1 Guys, do you test stuff before you release? Created attachment 100220 [details]
Refactored for Plasma 5.7.2: John Salatas's plasma-workspace-5.7.0-systray_iconsize.patch
Sigh :-(
The bug still appears in Plasma 5.7.2. BTW, Bob Wya's patch works well. I can not confirm this - after update to 5.7.2 I have the icon size in the systray that I had with versions <= 5.7.0 which I assume to be the correct size. Only version 5.7.1 showed the big icons in the panel for me. @cherenz@aip.de If you're using Fedora, I persuaded rdeiter to patch it at the package level. In which case, you won't see it in Fedora. I'm on openSUSE and I use the package from the KDE:Frameworks5 repository: https://build.opensuse.org/package/show?project=KDE%3AFrameworks5&package=plasma5-desktop @cherenz@aip.de You have no problem, because OpenSuse has already included the patch into their build: https://build.opensuse.org/package/view_file/KDE:Frameworks5/plasma5-workspace/Configuration-option-for-System-Tray-icon-size.patch?expand=1 So, waiting for this patch to be released in 5.7.3 (it is in master branch in git, but didn't come to 5.7.2). Still not fixed in 5.7.5 :( Looking into git, I see that the fix is only merged to 5.7.95/5.8. In 5.8.0, minimized windows show a black rectangle if the option to keep thumbnails of hidden windows in memory is disabled. I don't think that's any more beautiful than pixelated icons. ;-) |