| Summary: | Yakuake forgets profile settings | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Michael Husmann <michaelhusmann> |
| Component: | kpart | Assignee: | Konsole Bugs <konsole-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bug, leszek.lesner, mcv, rdieter, wbauer1 |
| Priority: | NOR | ||
| Version First Reported In: | 16.04.2 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/konsole/b9261c58ab2cf91ec090e4ad15064286a5366642 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Michael Husmann
2016-06-15 05:49:33 UTC
(In reply to Michael Husmann from comment #0) > When editing the standard profile all settings are lost when restarting > yakuake I can confirm this here. The problem seems to be that yakuake writes the modified profile to ~/.local/share/yakuake/, while konsole-part only reads the profiles from ~/.local/share/konsole/ apparently. I'm not sure whether this is a bug in yakuake or konsole(-part) though. > Yakuake does not reflect the konsole settings Modifying the profile in konsole should also affect yakuake. At least that's the case here. This is actually a bug/regression in konsole.
konsole's ProfileWriter.cpp has been changed to:
#if QT_VERSION < QT_VERSION_CHECK(5, 4, 0)
static const QString localDataLocation = QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/konsole");
#else
static const QString localDataLocation = QStandardPaths::writableLocation(QStandardPaths::AppLocalDataLocation);
#endif
AppLocalDataLocation contains the application name, which is "yakuake" if it is embedded in yakuake.
But the ProfileReader.cpp still uses:
QStandardPaths::writableLocation(QStandardPaths::GenericDataLocation) + QStringLiteral("/konsole");
So there's a mismatch when built against Qt 5.4.0 or higher (if konsole-part is embedded in another application than konsole).
Reassigning to konsole therefore.
*** Bug 362751 has been marked as a duplicate of this bug. *** Git commit b9261c58ab2cf91ec090e4ad15064286a5366642 by Kurt Hindenburg. Committed on 03/07/2016 at 16:26. Pushed by hindenburg into branch 'master'. Write profile changes to Konsole's location, not KPart's app Thanks to Wolfgang Bauer (wbauer tmo at) for patch REVIEW:128342 M +4 -4 src/ProfileWriter.cpp http://commits.kde.org/konsole/b9261c58ab2cf91ec090e4ad15064286a5366642 *** Bug 363449 has been marked as a duplicate of this bug. *** *** Bug 360424 has been marked as a duplicate of this bug. *** |