Bug 364023

Summary:	Some brush presets cannot be added to favorites.
Product:	[Applications] krita	Reporter:	brummerke90
Component:	General	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	brummerke90, halla, kwadraatnope, lloerau, osxyz, scottpetrovic
Priority:	NOR	Keywords:	regression
Version First Reported In:	3.0
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description brummerke90 2016-06-06 14:28:50 UTC

Some brushes can't be added to a custom brush tag.

Reproducible: Always

Steps to Reproduce:
1. Select freehand brush tool
2. Open up "choose brush preset"
3. Select the tag "all" at the top
4. Right click on clone tool
5. Assign to a tag, like the existing Favorite tag or a new, empty tag
6. select that tag at the top

Actual Results:  
The assigned (clone stamp) tool is not visible in either the brush presets tag menu nor the pop-up right click menu with the tags.

Expected Results:  
The brush should be added to the desired menu.

Comment 1 Bollebib 2016-06-29 16:03:47 UTC

I also encounter this issue

Comment 2 Bollebib 2016-06-29 16:09:16 UTC

confirmed for me as well,so i'm changing the status to help triage

Comment 3 brummerke90 2016-06-29 16:58:22 UTC

Have you guys tried restarting krita after adding it? Sometimes it works, seems like some changes don't take effect until a restart. Can anyone confirm?

Comment 4 wolthera 2016-07-08 13:59:52 UTC

*** Bug 362177 has been marked as a duplicate of this bug. ***

Comment 5 eliotJ 2016-07-20 17:08:42 UTC

It looks like I found when it worked and when not... It's also some kind of workaround.

Simply adding tag for selected Brush preset working from 'Dockers >> Brush Presets' and doesn't work from 'Choose brush preset'.

I tested on Win 7, Krita: http://files.kde.org/krita/3/windows/devbuilds/krita-3.0-0af993a-x86.zip

Comment 6 Scott Petrovic 2017-03-19 02:10:04 UTC

This seems to work when I test the latest master branch on my Ubuntu 16.10 box

1. Select freehand brush
2. click the choose a preset from the toolbar
3. add the clone tool to the favorite tag

The clone brush appears on both my pop-up menu and Brush preset docker.

I see elliotJ mentioned a build in the last comment, but the one he referenced in the link is from July 2016. Maybe he can try out a newer version. The latest nightlies can be downloaded on the link at the bottom of the download page.

(visit the bottom of the krita download page to find this link)
https://ci.appveyor.com/project/alvinhochun/krita-packaging/build/artifacts

I did some work on the brush presets docker and the brush editor with some fixes, so it also might have 'accidently' got fixed with something with that. Let us know if the master build still has the issue for you