| Summary: | git master: editing a title clip does not invalidate preview render chunks covered by this title clip | ||
|---|---|---|---|
| Product: | [Applications] kdenlive | Reporter: | Wegwerf <wegwerf-1-2-3> |
| Component: | User Interface & Miscellaneous | Assignee: | Jean-Baptiste Mardelle <jb> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Wegwerf
2016-06-03 15:40:38 UTC
Git commit 4bef7eb9367e985ad9e28df11ceccaf3c425c59e by Jean-Baptiste Mardelle. Committed on 04/06/2016 at 21:44. Pushed by mardelle into branch 'master'. Timeline preview fixes Related: bug 363900, bug 363902 M +6 -3 src/doc/kdenlivedoc.cpp M +1 -0 src/doc/kdenlivedoc.h M +1 -1 src/main.cpp M +3 -1 src/mainwindow.cpp M +1 -0 src/mainwindow.h M +3 -0 src/mltcontroller/producerqueue.cpp M +2 -0 src/mltcontroller/producerqueue.h M +12 -5 src/project/dialogs/projectsettings.cpp M +1 -0 src/project/dialogs/projectsettings.h M +2 -2 src/project/projectmanager.cpp M +27 -21 src/timeline/customtrackview.cpp M +79 -35 src/timeline/managers/previewmanager.cpp M +16 -18 src/timeline/timeline.cpp M +3 -6 src/timeline/timelinecommands.cpp M +1 -1 src/timeline/timelinecommands.h M +35 -5 src/timeline/track.cpp M +2 -2 src/timeline/track.h M +2 -17 src/timeline/transitionhandler.cpp M +1 -1 src/timeline/transitionhandler.h M +1 -1 src/utils/progressbutton.cpp http://commits.kde.org/kdenlive/4bef7eb9367e985ad9e28df11ceccaf3c425c59e This now works as expected, with the only minor issue that it seems to be very generous on invalidating the preview rendering zones. It seems as if the current implementation invalidates timeline preview zones based on the length of the title clip in the project bin, but not on the real clip lengths in the timeline. For instance, my default setting for title and image clips is 00:00:06:00. Yet in the timeline I shortened the title clip to only 04:00. However, editing the title clip invalidates 6 seconds in the preview rendering zone. While this doesn't really matter for timeline title clips shorter than the title clip length in the project bin, it causes incomplete invalidation of preview rendering when a title clip in the timeline has been resized to be longer than its default setting in the project bin. Git commit dea28a5993a2ab9c7f8a5c50be23a23c325ab08f by Jean-Baptiste Mardelle. Committed on 05/06/2016 at 09:04. Pushed by mardelle into branch 'master'. Fix changing clip resulting in unnecessary preview invalidation M +3 -3 src/timeline/track.cpp http://commits.kde.org/kdenlive/dea28a5993a2ab9c7f8a5c50be23a23c325ab08f Looks good now! Thank you very much for fixing this, Jean-Baptiste! |