| Summary: | background-size inherit/initial fails to apply in some cases | ||
|---|---|---|---|
| Product: | [Applications] konqueror | Reporter: | Andrea Iacovitti <aiacovitti> |
| Component: | khtml renderer | Assignee: | Konqueror Bugs <konqueror-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Other | ||
| Latest Commit: | http://commits.kde.org/kdelibs/dee3cce6f343c298fc23a1fdd77b880aacf3c354 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
image needed for testcase
testcase1 - inherit testcase2 - initial |
||
|
Description
Andrea Iacovitti
2016-05-29 19:10:14 UTC
Created attachment 99247 [details]
image needed for testcase
Created attachment 99248 [details]
testcase1 - inherit
Created attachment 99249 [details]
testcase2 - initial
Git commit dee3cce6f343c298fc23a1fdd77b880aacf3c354 by Andrea Iacovitti. Committed on 29/05/2016 at 21:25. Pushed by aiacovitti into branch 'KDE/4.14'. Fix applying Initial and Inherit for background-size property. Need to set both type and lengths of bg-size, currently only lengths was set using setBackgroundSize() (see HANDLE_BACKGROUND_VALUE macro). Remove separate handling of type and lengths as they are interdependent and use setBackgroundSize() to set both, making this code less error-prone and avoiding dealing with the macro. M +8 -8 khtml/css/css_renderstyledeclarationimpl.cpp M +4 -8 khtml/css/cssstyleselector.cpp M +2 -2 khtml/rendering/render_box.cpp M +2 -5 khtml/rendering/render_style.cpp M +17 -9 khtml/rendering/render_style.h http://commits.kde.org/kdelibs/dee3cce6f343c298fc23a1fdd77b880aacf3c354 |