Bug 363660

Summary:	Grid visibility is poor
Product:	[Applications] kblackbox	Reporter:	Andrej M. <andrejm>
Component:	general	Assignee:	Nicolas Roffet <nicolas-kde>
Status:	RESOLVED FIXED
Severity:	minor	CC:	aacid, cfeck, kde-games-bugs-null, keyvin
Priority:	NOR	Keywords:	junior-jobs
Version First Reported In:	0.4
Target Milestone:	---
Platform:	Debian stable
OS:	Linux
Latest Commit:	https://commits.kde.org/kblackbox/cb6d38cadfc1225e164f596ce73bef42222d35a8	Version Fixed In:
Sentry Crash Report:
Attachments:	Patch to correct this problem

Description Andrej M. 2016-05-29 11:20:26 UTC

Dear developers,

the main game area has a gradient background applied to the grid which makes the latter really poorly visible. This is not a problem when playing with keyboard, as the selected cells are highlighted, but when playing with mouse you have to put too much focus into clicking the right cell, which kind of ruins the game.

I see two possible solutions:
a) highlight the cell on mouse hover as this is the case with keyboard play
b) remove the gradient

Best regards,
Andrej

Comment 1 Christoph Feck 2016-05-30 02:29:47 UTC

Solution a) should be easy to do.

Another option would be to support themes like other KDE games do.

Comment 2 keyvin 2018-01-10 23:53:23 UTC

Created attachment 109787 [details]
Patch to correct this problem

Added an option under the settings menu to enable/disable a cursor under the mouse.

Comment 3 Albert Astals Cid 2018-01-14 22:20:20 UTC

I'm not really a kblackbox player, but i'm reviewing the patch because i don't think anyone else will.

Do we really need this to be an option?

I think it really makes sense to always have the highlight follow the mouse, no?

Comment 4 keyvin 2018-01-15 00:57:57 UTC

I made it an option because I was worried the new behavior would be undesirable or annoying for players used to the current behavior. I can remove the option if it make more sense to always have the cursor on.

Comment 5 Albert Astals Cid 2018-01-15 21:12:10 UTC

As said i'm not really a kblackbox player, so can't give a hard answer, but from looking at it i think we can at least enable it by default and if someone really dislikes it, they can go an disable it.

I'll give a quick review to the patch and commit it if i don't think anything wrong.

Comment 6 Albert Astals Cid 2018-01-15 21:41:38 UTC

Can i have your full name for proper authorship attribution?

Comment 7 keyvin 2018-01-15 22:59:00 UTC

Kevin Price.

Comment 8 Albert Astals Cid 2018-01-15 23:28:36 UTC

Git commit cb6d38cadfc1225e164f596ce73bef42222d35a8 by Albert Astals Cid, on behalf of Kevin Price.
Committed on 15/01/2018 at 23:10.
Pushed by aacid into branch 'master'.

Added an option under the settings menu to enable a cursor under the mouse

Contains some tweaks by Albert Astals Cid (whitespaces et al)

M  +2    -0    kbbgraphicsitemball.cpp
M  +16   -1    kbbgraphicsitemblackbox.cpp
M  +11   -4    kbbgraphicsitemblackbox.h
M  +1    -2    kbbgraphicsitemcursor.h
M  +1    -1    kbblevelconfigurationpreview.cpp
M  +8    -1    kbbmainwindow.cpp
M  +1    -1    kbbmainwindow.h
M  +23   -2    kbbscalablegraphicwidget.cpp
M  +4    -0    kbbscalablegraphicwidget.h
M  +4    -1    kblackboxui.rc

https://commits.kde.org/kblackbox/cb6d38cadfc1225e164f596ce73bef42222d35a8

Comment 9 Albert Astals Cid 2018-01-15 23:29:30 UTC

As you see I commited your patch, i've also made two small follow up commits, please comment if you disagree 

https://cgit.kde.org/kblackbox.git/commit/?id=1b137d305d3c898ae292ebb761f7dcb505c7c9a6
https://cgit.kde.org/kblackbox.git/commit/?id=9b100d33a36e79c92a19fdd612b4d371e5705a0f