Bug 363220

Summary:	replace all notification duplicated when scrolling down
Product:	[Applications] kate	Reporter:	Patrick Roye <patrick.roye>
Component:	search	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	missive, rohan
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Microsoft Windows
Latest Commit:	http://commits.kde.org/ktexteditor/14a165ac4a32570e0de7b50a7dcce66ff7ab11fa	Version Fixed/Implemented In:	KDE Frameworks 5.24
Sentry Crash Report:
Attachments:	Screenshot of replacements made bug in action

Description Patrick Roye 2016-05-18 13:16:38 UTC

After pressing Replace All, a green box appears in the bottom-right of the document displaying the number of replacements made. If you scroll down the document while the box is visible, the box is duplicated. The effect occurs when scrolling with arrow keys or the mouse wheel. The effect does not occur when using page up / page down.

Reproducible: Always

Steps to Reproduce:
1. Open a document that is large enough to scroll
2. Press ctrl-r
3. Press Replace All
4. Scroll down with the mouse wheel

Actual Results:  
The replacements made box appears multiple times on the right-hand side

Expected Results:  
The replacements made box appears once in the bottom-right corner

Kate version 16.07.70 built from source on Windows using Visual Studio 2015.

Comment 1 Patrick Roye 2016-05-18 13:21:08 UTC

Created attachment 99049 [details]
Screenshot of replacements made bug in action

Comment 2 Dominik Haumann 2016-06-15 16:04:09 UTC

Git commit 14a165ac4a32570e0de7b50a7dcce66ff7ab11fa by Dominik Haumann.
Committed on 15/06/2016 at 16:04.
Pushed by dhaumann into branch 'master'.

Fix drawing artifacts when scrolling while notifications are visible
REVIEW: 128195

M  +8    -8    autotests/src/messagetest.cpp
M  +1    -0    src/view/katemessagewidget.cpp
M  +0    -1    src/view/kateview.cpp
M  +5    -5    src/view/kateview.h
M  +5    -8    src/view/kateviewinternal.cpp

http://commits.kde.org/ktexteditor/14a165ac4a32570e0de7b50a7dcce66ff7ab11fa

Comment 3 Dominik Haumann 2016-06-15 16:07:18 UTC

Will ship with the next KDE Frameworks release - thanks for the report :-)

You can of course also build with visual studio and try yourself.

Comment 4 Dominik Haumann 2016-06-15 16:17:24 UTC

*** Bug 351453 has been marked as a duplicate of this bug. ***

Comment 5 Dominik Haumann 2016-06-15 16:18:16 UTC

*** Bug 334550 has been marked as a duplicate of this bug. ***

Comment 6 Patrick Roye 2016-06-17 14:22:48 UTC

I can confirm that this issue is fixed for me. Thank you so much for taking the time to resolve this issue!

Comment 7 Dominik Haumann 2016-09-07 10:29:39 UTC

Unfortunately, this introduced a bad regression: If a message widget is shown *above* the view twice, it always crashes. Since Kate does not show many message widgets on top, this is seldom, though.

KDE Frameworks 5.27 will properly fix this, and we hope the scrolling artifacts are still gone then.

Patrick Roye: Please test again with 5.27 :-)
You could even do so by testing this with the Neon live image with tomorrows build (https://neon.kde.org/).