| Summary: | More margins for list items | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Alex L <alexlong92> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED INTENTIONAL | ||
| Severity: | normal | CC: | thomas.pfeiffer |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: | More margins for list items | ||
Git commit 0378ab2d0cf807484bcb86a21ec8f6ce0f363cc1 by Marco Martin. Committed on 27/04/2016 at 15:24. Pushed by mart into branch 'master'. same height for AbstractListItem and SwipeListItem calculate the height of AbstractListItem and SwipeListItem in the exact same way. it may still need some adjustment but we are sure they will be consisten one to each other M +2 -2 examples/gallery/contents/ui/MainPage.qml M +1 -1 src/qml/AbstractListItem.qml M +2 -1 src/qml/BasicListItem.qml M +2 -2 src/qml/GlobalDrawer.qml M +1 -4 src/qml/SwipeListItem.qml http://commits.kde.org/kirigami/0378ab2d0cf807484bcb86a21ec8f6ce0f363cc1 I don't think the current height is a problem. We can reopen this if we get complaints from users. |
Created attachment 98611 [details] More margins for list items See the attached image (left: current look, right: proposed). The list items are too small, it's hard to interact with them (both tapping and drag them by the handles on the right side of each item). Suggested changes: 1) more margins between list items and right/left border (the margins should be the same at right and left, symmetrical); 2) more margins between the list items (top and bottom) for an idea of how much to increase margins, look at the attached image.