Bug 361670

Summary:	More contrast for highlighting of special (formatting/layouting) chars in sources/translations
Product:	[Applications] lokalize	Reporter:	Friedrich W. H. Kossebau <kossebau>
Component:	editor	Assignee:	Nick Shaforostoff <shafff>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version First Reported In:	2.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	http://commits.kde.org/lokalize/d48e53790185da58196640f937ae3a1a50c2e048	Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot: no-break space highlighting almost invisible

Description Friedrich W. H. Kossebau 2016-04-12 14:01:10 UTC

UTF charsets contain various characters which help with layouting/formatting. E.g. the NO-BREAK SPACE. Given those are valid chars, tooling usually properly deals with those, even more the code where the actual string is used by (e.g. for rendering on the screen), which respects the layouting/formatting instructions given by those chars (in the example of NO-BREAK SPACE doing no word-wrap at this space).

Right now a developer using kf5 and wanting to make sure translators do not miss the no-break space would have to use xi18n and &nbsp; in the string, which adds runtime costs. Just because the translation tool does not properly support translation with such special chars.
Please let's get this improved :)

Reproducible: Always

Comment 1 Nick Shaforostoff 2016-04-13 08:42:58 UTC

non-breakable space is already being highlighted with light grey (there is even bug 327320 and bug 360823 about that)

Comment 2 Friedrich W. H. Kossebau 2016-04-13 10:48:57 UTC

Created attachment 98372 [details]
Screenshot: no-break space highlighting almost invisible

Comment 3 Friedrich W. H. Kossebau 2016-04-13 11:03:01 UTC

Oh, indeed you are right, there is highlighting already. But then I have to still request a change (and thus changed the bug title now):
at least to me the highlighting is barely noticeable with my current color scheme (which is the default of Plasma 5.6), as the initial bug report proves. And my eyes are not that bad :)

Please consider improving the contrast a little bit with any color schemes. See the attached screenshot, at least on my IPS display of my X220 I have to look 3x times to notice the highlight with bright color schemes (like the default Breeze theme of Plasma 5.6). It's clearly visible with dark schemes, but not with most(?) bright ones.

Comment 4 Nick Shaforostoff 2016-04-25 20:41:35 UTC

Git commit d48e53790185da58196640f937ae3a1a50c2e048 by Nick Shaforostoff.
Committed on 25/04/2016 at 20:40.
Pushed by shaforo into branch 'Applications/16.04'.

mark unbreakable space with more contrast
Related: bug 327320

M  +7    -3    src/syntaxhighlighter.cpp

http://commits.kde.org/lokalize/d48e53790185da58196640f937ae3a1a50c2e048