Bug 360656

Summary: CMake highlighting: OR/AND not highlighted after expr in ()
Product: [Frameworks and Libraries] frameworks-syntax-highlighting Reporter: Alexander Potashev <aspotashev>
Component: syntaxAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: christoph, jonathan.poelen
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Potashev 2016-03-17 12:18:09 UTC
If you type in "if((A AND B) OR C)", "OR" is not highlighted.

Reproducible: Always
Comment 1 Christoph Cullmann 2016-09-06 21:23:30 UTC
I think the problem is that "Macro Args" pops context on ) but we need to push on (, too, which is not that trivial, given Macro Args is included at several places
Comment 3 Dominik Haumann 2017-06-17 14:27:35 UTC
Git commit 714f17d79ab73c184bbb36adea8c3cde4989ef91 by Dominik Haumann, on behalf of Jonathan Poelen.
Committed on 17/06/2017 at 14:26.
Pushed by dhaumann into branch 'master'.

CMake: OR/AND not highlighted after expr in ()
Differential Revision: https://phabricator.kde.org/D6128

M  +2    -0    autotests/folding/highlight.cmake.fold
M  +3    -1    autotests/html/highlight.cmake.html
M  +2    -0    autotests/input/highlight.cmake
M  +3    -1    autotests/reference/highlight.cmake.ref
M  +24   -13   data/syntax/cmake.xml

https://commits.kde.org/syntax-highlighting/714f17d79ab73c184bbb36adea8c3cde4989ef91