| Summary: | Icon for mount error is missleading | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Franco Pellegrini <frapell> |
| Component: | Icons | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kainz.a, kde, thomas.pfeiffer |
| Priority: | NOR | ||
| Version First Reported In: | 5.5.3 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/breeze-icons/1e4e9de420634b86acf2aaf1163d56feea872403 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Error on mount
Device notifier Device Notifier and Error notification new mounted unmounted icons mount unmount icons |
||
|
Description
Franco Pellegrini
2016-02-02 19:35:00 UTC
Created attachment 96983 [details]
Error on mount
Created attachment 96984 [details]
Device notifier
please had a screnshoot. of the issue (In reply to pinheiro from comment #3) > please had a screnshoot. of the issue just noticed you did ... the only oxygen icon i see there is the encrypted one, the others are breeze, I'm not saying this is not a valid problem in oxygen, I'm saying that you need to check if its also valid in oxygen, the problem might be the coder that assigned an incorrect icon here. so please check against oxygen icons, if the problem is still there reopen the bug, if not reassign it to breeze And now i realized you might be talking about the encrypted icon. that one specifically means unopened encrypted emblem-encrypted-locked.png if it was opened available its should be emblem-encrypted-unlocked.png, so booth icons 2 exist, your confusion if it is what I'm guessing, is related with the UI/UX that shows that "check" icon on the other side, i'm not sure that is what is going on, but if it is you need to assign this bug to the person that made this UI. You are correct, this is Breeze, not Oxygen. Attaching new screenshot and reassigning after I post this comment. I'm talking about the Icon that shows up in the notification... Unless you stop and read "Could not mount...." is not obvious that it failed... Maybe it should show a big red X or something that makes it very clear that whatever you were trying to do, it failed... (btw, this is the very same icon that is used in oxygen) As a side note, from the device notifier menu, having that green icon is not very intuitive that it means "just mount the unit"... Created attachment 96994 [details]
Device Notifier and Error notification
Hi this interface will get an update with some new icons. so this is a remark that the new interface has to test also with encrypted files. Note this message does *not* come from Plasma 5 but the kdelibs4 variant of Solid (KDE hardware abstraction) which doesn't find the Plasma 4 device notifier und so falls back to the popup notification. Created attachment 99057 [details]
new mounted unmounted icons
emblem-mounted is a plug
emblem-unmounted is an eject
icon would it be better?
In my Personal opinion, it is better but still not 100% intuitive... This are my thoughts: - The orange icon means "unmount", not "unmounted" - I notice that the green icon is a plug, after being told it was a plug... maybe remove the connection between the pins? What about doing something like: - An icon like this https://upload.wikimedia.org/wikipedia/commons/thumb/5/59/Plug-in_Noun_project_4032.svg/2000px-Plug-in_Noun_project_4032.svg.png for when the device is not mounted - The same icon but "plugged", when the device has been mounted successfully - Just the male part of that for the "mount" action (Like the green one from your attachment, but without the union between the pins) - An icon like the orange one in your attachment for "unmount" action Just my 2 cents... Also, what KDE4 software are you still running? If you uninstall it, this stupid notification should not even appear. :) What do you mean with "stupid notification" ? it's the regular "Device notifier" that pops up when you plug in a new USB drive, etc... I'm on Kubuntu 16.04, using Plasma 5.5.5 and QT 5.5.1 HTH https://bugsfiles.kde.org/attachment.cgi?id=96983 ← This notification Ah, right, the action in device notifier is also not obvious, sorry for the noise :) No problem, we are all trying to make this software better :) Just to be clear... the notification is valid and it shows up when you try to mount an encrypted drive and you provide a wrong password... Created attachment 99105 [details]
mount unmount icons
better?
Looks like a "muted" icon to me How about something like this? http://www.iconarchive.com/show/windows-8-icons-by-icons8/Network-Disconnected-icon.html That clearly shows that it's an unplugged plug and cannot be confused for a speaker we are talking about 8x8 px icons that's the problem! Git commit 1e4e9de420634b86acf2aaf1163d56feea872403 by andreas kainz. Committed on 28/05/2016 at 23:43. Pushed by andreask into branch 'master'. update mount and unmount icon M +1 -1 icons-dark/emblems/8/checkmark.svg T +13 -1 icons-dark/emblems/8/emblem-checked.svg M +4 -7 icons-dark/emblems/8/emblem-mounted.svg M +1 -1 icons-dark/emblems/8/emblem-success.svg M +9 -9 icons-dark/emblems/8/emblem-unmounted.svg M +1 -1 icons/emblems/8/checkmark.svg T +13 -1 icons/emblems/8/emblem-checked.svg M +4 -7 icons/emblems/8/emblem-mounted.svg M +1 -1 icons/emblems/8/emblem-success.svg M +9 -9 icons/emblems/8/emblem-unmounted.svg http://commits.kde.org/breeze-icons/1e4e9de420634b86acf2aaf1163d56feea872403 Why is this marked as fixed? did you commit the icons from your comment #17 ? (I cannot see them from the commits.kde.org link) If so, as Kai points out, they are clearly not intuitive icons for knowing if a device is mounted or not... They are confusing |
