| Summary: | Usability: replace (un)expand icon button with "Show/hide details" link button | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Gregor Mi <codestruct> |
| Component: | Notifications | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | plasma-bugs, thomas.pfeiffer |
| Priority: | NOR | Flags: | mklapetek:
VisualDesign+
|
| Version: | 5.5.3 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/994de033983c32fca24f09465cf9b98b3e28f568 | Version Fixed In: | 5.5.4 |
| Sentry Crash Report: | |||
|
Description
Gregor Mi
2016-01-20 22:09:53 UTC
Thanks for the report Yes the icons looks weird, it's mostly a remnant from kde4 times when the icon "list-remove" was a minus sign. Now it's a stop sign for whatever reason. Looking over all the "actions" icon, I did not however find an icon pair for "expand/collapse". The best one I could find is "arrow-down" and "arrow-up", but that doesn't feel right, especially since it can change into actual arrow at any point and just look weird. VDG, what's your recommendation for an icon here? Or maybe the button should go away altogether and it should be clickable in the same way as device notifier and network manager applets' lists are? Ie. no button but the whole list item is clickable and it expands on clicking. Arrow-right and arrow-down are used for expandable list items, so reusing it here does sound very sensible to me. Why would we introduce a new icon for the same thing? Git commit 994de033983c32fca24f09465cf9b98b3e28f568 by Martin Klapetek. Committed on 21/01/2016 at 00:32. Pushed by mklapetek into branch 'Plasma/5.5'. [notifications] Replace the icon on the button to expand the running job Use arrows instead. FIXED-IN: 5.5.4 M +1 -1 applets/notifications/package/contents/ui/JobDelegate.qml http://commits.kde.org/plasma-workspace/994de033983c32fca24f09465cf9b98b3e28f568 Git commit d6baf450d3ff4cf87461f0b32eef73d12298cb0a by Martin Klapetek. Committed on 21/01/2016 at 00:34. Pushed by mklapetek into branch 'master'. [notifications] Add a button tooltip to the expanding button New string, master only. M +2 -0 applets/notifications/package/contents/ui/JobDelegate.qml http://commits.kde.org/plasma-workspace/d6baf450d3ff4cf87461f0b32eef73d12298cb0a |