|Summary:||Distinguish holidays from other events|
|Product:||[Frameworks and Libraries] frameworks-plasma||Reporter:||Vadym Krevs <vkrevs>|
|Component:||components||Assignee:||Martin Klapetek <mklapetek>|
|Severity:||wishlist||CC:||andrew.crouthamel, aspotashev, bugseforuns, justin.zobel, kde, kde, nate, plasma-bugs, sabayon11|
|Latest Commit:||http://commits.kde.org/plasma-workspace/e8c5a28df28d2d66e8eaee47550425941e3e7ade||Version Fixed In:|
calendar in plasma 5.15.2
Description Vadym Krevs 2016-01-07 09:35:08 UTC
This is a regression. In KDE 4.14, the calendar popup wrapped each bank holiday in a thin red line. In 5.5.2 this useful feature is gone. Reproducible: Always Steps to Reproduce: 1. Click on the digital clock in the panel. Pop up calendar appears. 2. Scroll to January or December. 3. Actual Results: Public holidays (Jan 1st, etc) are indistingushable from normal days. Expected Results: Public holidays (Jan 1st, etc) are highlighted and are easily identified.
Comment 1 Martin Klapetek 2016-01-07 17:23:54 UTC
Thanks for the report This feature should be ready for Plasma 5.6
Comment 2 Martin Klapetek 2016-05-03 00:20:56 UTC
Git commit e8c5a28df28d2d66e8eaee47550425941e3e7ade by Martin Klapetek. Committed on 03/05/2016 at 00:20. Pushed by mklapetek into branch 'master'. Revert "Revert all of the Calendar-agenda changes" This reverts commit 697aaf8067ebac4c649895e57eff73a5f071b430 and brings back the agenda part of calendar. REVIEW: 127734 Related: bug 349676 FIXED-IN: 5.7 M +25 -5 applets/digital-clock/package/contents/config/config.qml M +3 -0 applets/digital-clock/package/contents/config/main.xml M +157 -12 applets/digital-clock/package/contents/ui/CalendarView.qml M +1 -6 applets/digital-clock/package/contents/ui/configAppearance.qml A +72 -0 applets/digital-clock/package/contents/ui/configCalendar.qml [License: GPL (v2/3)] M +5 -1 applets/digital-clock/package/contents/ui/main.qml http://commits.kde.org/plasma-workspace/e8c5a28df28d2d66e8eaee47550425941e3e7ade
Comment 3 Kai Uwe Broulik 2016-06-01 08:26:18 UTC
*** Bug 363775 has been marked as a duplicate of this bug. ***
Comment 4 Vadym Krevs 2016-06-01 10:46:46 UTC
So, I am on openSUSE Leap 42.1 with Plasma 5.6.4. $ rpm -qa | grep plasma plasma5-addons-5.6.4-93.1.x86_64 python-kde4-plasma-4.14.3-2.11.x86_64 plasma5-session-5.6.4-70.1.noarch plasma5-addons-lang-5.6.4-93.1.noarch plasma-nm5-openconnect-5.6.4-108.1.x86_64 plasma-framework-lang-5.22.0-123.1.noarch plasma-nm5-vpnc-5.6.4-108.1.x86_64 plasma-framework-private-5.22.0-123.1.x86_64 plasma5-desktop-lang-5.6.4-163.1.noarch plasma5-workspace-lang-5.6.4-203.1.noarch plasma5-pa-lang-5.6.4-40.1.noarch plasma-nm5-lang-5.6.4-108.1.noarch plasma5-pk-updates-lang-0.2-17.1.noarch plasma5-workspace-5.6.4-203.1.x86_64 plasma-nm5-pptp-5.6.4-108.1.x86_64 plasma5-workspace-libs-5.6.4-203.1.x86_64 plasma-nm5-5.6.4-108.1.x86_64 patterns-openSUSE-kde_plasma-20150918-12.1.x86_64 plasma5-workspace-branding-openSUSE-13.3-128.1.x86_64 plasma5-desktop-5.6.4-163.1.x86_64 plasma5-workspace-wallpapers-5.6.4-62.1.noarch plasma5-pk-updates-0.2-17.1.x86_64 plasma5-desktop-branding-openSUSE-13.3-128.1.x86_64 plasma5-pa-5.6.4-40.1.x86_64 plasma-nm5-openvpn-5.6.4-108.1.x86_64 plasma5-integration-plugin-5.6.4-6.1.x86_64 plasma-framework-components-5.22.0-123.1.x86_64 plasma-framework-5.22.0-123.1.x86_64 plasma5-desktop-kimpanel-5.6.4-163.1.x86_64 plasma5-pk-updates-debuginfo-0.2-17.1.x86_64 According to comment 1, this should have been fixed, but it is not. When can we expect this to land in any released version of Plasma?
Comment 5 apache 2016-06-01 12:37:31 UTC
You closed bug 363775 but please don't ignore remarks about: "today's date was highlighted, holidays were highlighted, ability to copy date, to skip weeks (to see what date will be in a week time). Calendar in Plasma 5 lacks all of the above. Please bring back this functions." Just compare: http://i.imgur.com/XAJYITc.png
Comment 6 Martin Klapetek 2016-06-01 12:47:10 UTC
> According to comment 1, this should have been fixed, but it is not. When can we expect this to land in any released version of Plasma? As you can read in that very comment, it says Fixed in Plasma 5.7. > You closed bug 363775 but please don't ignore remarks about ... Couple things - multiple issues should always go into separate reports, there's no sensible way to handle them in a single report. That said, in 5.7 holidays are marked, today is highlighted, ability to copy date and you can skip dates by month/year/decade. In other words, everything from your list.
Comment 7 apache 2016-06-01 12:57:50 UTC
It only says "brings back the agenda part of calendar." I don't have Plasma 5.7 yet so I wasn't aware. But, if this is the case, then please, let me apologise. I appreciate that you adjusted it to the need of users. Thank you. Have a nice day.
Comment 8 Vadym Krevs 2016-06-01 18:47:40 UTC
(In reply to Martin Klapetek from comment #6) > > According to comment 1, this should have been fixed, but it is not. When can we expect this to land in any released version of Plasma? > > As you can read in that very comment, it says Fixed in Plasma 5.7. > > > You closed bug 363775 but please don't ignore remarks about ... > > Couple things - multiple issues should always go into separate reports, > there's no sensible way to handle them in a single report. That said, in 5.7 > holidays are marked, today is highlighted, ability to copy date and you can > skip dates by month/year/decade. In other words, everything from your list. Sorry, I missed the "fixed in plasma 5.7" part. Thank you.
Comment 9 Vadym Krevs 2016-06-25 10:49:14 UTC
Installed Plasma 5.7 beta packages from OBS. The calendar popup still does not highlight holidays. $ rpm -qa | grep plasma plasma5-pk-updates-lang-0.2-17.2.noarch plasma-theme-aya-15.08.3-1.6.noarch plasma-nm5-openvpn-5.6.95-111.1.x86_64 plasma-nm5-5.6.95-111.1.x86_64 plasma5-pa-lang-5.6.95-44.1.noarch plasma5-pk-updates-0.2-17.2.x86_64 plasma-framework-components-5.23.0-127.1.x86_64 plasma5-workspace-libs-5.6.95-215.1.x86_64 plasma5-desktop-5.6.95-169.1.x86_64 plasma5-addons-lang-5.6.95-95.1.noarch plasma5-desktop-branding-upstream-5.6.95-169.1.x86_64 plasma5-workspace-branding-upstream-5.6.95-215.1.x86_64 plasma-framework-lang-5.23.0-127.1.noarch plasma-nm5-pptp-5.6.95-111.1.x86_64 plasma5-workspace-lang-5.6.95-215.1.noarch plasma5-pa-5.6.95-44.1.x86_64 plasma5-desktop-lang-5.6.95-169.1.noarch plasma-framework-5.23.0-127.1.x86_64 plasma5-addons-5.6.95-95.1.x86_64 plasma-framework-private-5.23.0-127.1.x86_64 plasma5-workspace-5.6.95-215.1.x86_64 python-kde4-plasma-4.14.3-2.11.x86_64 plasma5-desktop-kimpanel-5.6.95-169.1.x86_64 plasma5-workspace-debuginfo-5.6.95-215.1.x86_64 plasma-nm5-vpnc-5.6.95-111.1.x86_64 plasma-theme-oxygen-16.04.2-2.4.x86_64 plasma-nm5-openconnect-5.6.95-111.1.x86_64 plasma-nm5-lang-5.6.95-111.1.noarch plasma5-integration-plugin-5.6.95-10.1.x86_64
Comment 10 apache 2016-06-25 17:51:40 UTC
I see that you have aya theme. Unfortunately holidays are only visible in Breeze I reported another bug to address this issue: https://bugs.kde.org/show_bug.cgi?id=364472 I also wrote about usability aspect of this problem here https://forum.kde.org/viewtopic.php?f=285&t=133463
Comment 11 Vadym Krevs 2016-06-25 18:15:05 UTC
No, my workspace theme in System Settings is Breeze Dark, not aya.
Comment 12 Vadym Krevs 2016-07-07 08:37:37 UTC
Installed final Plasma 5.7 rpms from OBS. Still no joy with either Breeze or Breeze Dark.
Comment 13 apache 2016-07-07 10:25:26 UTC
Comment 14 David Edmundson 2016-07-07 22:48:53 UTC
No, my workspace theme in System Settings is Breeze Dark, not aya. Screenshot please.
Comment 15 Vadym Krevs 2016-07-08 08:15:31 UTC
Created attachment 99943 [details] requested screenshot Here you go.
Comment 16 Andrew Crouthamel 2018-09-26 22:09:46 UTC
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
Comment 17 Vadym Krevs 2018-09-27 08:13:38 UTC
Dear Andrew Crouthamel. I have provided the needinfo 2 years ago.
Comment 18 Andrew Crouthamel 2018-09-27 20:31:32 UTC
Thanks, I've set this to REPORTED so it won't be auto-closed.
Comment 19 Patrick Silva 2019-03-01 19:22:57 UTC
Created attachment 118463 [details] calendar in plasma 5.15.2 Holidays are highlighted in plasma 5.15.2. See my screenshot.
Comment 20 Dmitri Koulikoff 2021-01-16 16:59:10 UTC
Created attachment 134942 [details] calender I have Operating System: Slackware-current KDE Plasma Version: 5.20.5 KDE Frameworks Version: 5.78.0 Qt Version: 5.15.2 Kernel Version: 5.10.6 OS Type: 64-bit Processors: 12 × Intel® Core™ i7-9750H CPU @ 2.60GHz Memory: 31.1 GiB of RAM Graphics Processor: Mesa Intel® UHD Graphics 630 and I can not distinguish full Moon event from a holiday.
Comment 21 Justin Zobel 2021-01-17 09:00:52 UTC
Confirmed on 5.20.5. I enabled Holidays. Selected my Holidays for my state but they do not show up in the calendar.