Bug 357004

Summary:	only 8 lines shown in the tooltip subtext of applets
Product:	[Plasma] plasmashell	Reporter:	Pino Toscano <pino>
Component:	general	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, luigi.toscano, mklapetek, notuxius, plasma-bugs-null, sebas
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	unspecified
OS:	All
See Also:	https://bugs.kde.org/show_bug.cgi?id=357005
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Pino Toscano 2015-12-21 16:26:34 UTC

Due to commit d285b818f637f8e30f4239b0f724b73db260b111 in plasma-framework, the default subtext for plasma tooltips has 8 lines; considering that the digital clock uses the first two lines to show the time in the current timezone and as empty spacer, it effectively leaves only 6 timezones shown in the tooltip of the clock.

Reproducible: Always

Steps to Reproduce:
1. add a digital clock applet
2. select more than 6 timezones in the configuration of the clock applet
3. look at the tooltip of the applet

Actual Results:  
The tooltip of the applet shows 6 timezones instead of all the selected ones.

Expected Results:  
All the selected timezones are shown in the tooltip; or, in general, all the lines set by the applet should be shown.

The referenced commit adds that limit in what seems a way to workaround some problem in klipper; ideally, this hack should be removed, and klipper fixed (if still buggy).

Comment 1 Pino Toscano 2015-12-21 16:27:43 UTC

CCing sebas, who did the aforementioned commit in plasma-workspace.

Comment 2 Martin Klapetek 2015-12-21 18:54:14 UTC

Thanks for the report

Just out of curiosity, how many timezones you actually have/need?

Comment 3 Luigi Toscano 2015-12-21 19:13:50 UTC

/me jumps in 

The old clock status was/is a really good tool when interacting with colleagues around, so that I had 18 timezones. I could kill 3 of them, but still...
 (the aspect itself of the tooltip and the time it stays open are matters for other bugs :)

Comment 4 Martin Klapetek 2016-01-04 18:03:42 UTC

Git commit f5297033c4a0fba416b971f2bdbcb04c56858947 by Martin Klapetek.
Committed on 04/01/2016 at 18:03.
Pushed by mklapetek into branch 'master'.

[digital-clock] Improve clock's tooltip layout

In kde4 times, the layout of clock's tooltip was nicely arranged using a
table. Now it's a bit of a mess so this brings back some nice layout.

Also simplifies the timeForZone function which is used only for the
tooltip.
Related: bug 357005, bug 351472
FIXED-IN: 5.6.0
REVIEW: 124047

M  +11   -57   applets/digital-clock/package/contents/ui/DigitalClock.qml
A  +137  -0    applets/digital-clock/package/contents/ui/Tooltip.qml     [License: LGPL (v2+)]
M  +10   -3    applets/digital-clock/package/contents/ui/main.qml
M  +1    -0    applets/digital-clock/plugin/timezonedata.h
M  +18   -1    applets/digital-clock/plugin/timezonemodel.cpp
M  +3    -0    applets/digital-clock/plugin/timezonemodel.h

http://commits.kde.org/plasma-workspace/f5297033c4a0fba416b971f2bdbcb04c56858947

Comment 5 Alexander Mentyu 2017-11-28 18:50:34 UTC

Currently there's more than 8 time zones in 'Digital Clock' tooltip - issue is resolved

Distribution: KDE neon Developer Edition - Stable Branches
Plasma: 5.11.3
Frameworks: 5.41.0
Qt: 5.9.2
Kernel 4.10.0-38-generic
Type: 64-bit