Summary: | IconItem does not support non-square icons | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libplasma | Reporter: | garwol <garwol4130> |
Component: | components | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | g-a-d, garwol4130, gcala, gilles.turgeon, jdchoate, kde, kde, lbeltrame, mahen, mkyral, nikonovds, pepko94, phelps.sg, plasma-bugs, scootalootf2, shibotto |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-framework/d46a91ea57f19e33e6f3a08ec86084b7e11a8e1a | Version Fixed In: | |
Attachments: |
screenshot
screenshot screenshot |
Description
garwol
2015-11-19 14:18:11 UTC
Created attachment 95601 [details]
screenshot
Same for me Created attachment 96123 [details]
screenshot
plasma 5.5.1 - icons still stretched *** Bug 347268 has been marked as a duplicate of this bug. *** This is actually a bug in the Plasma IconItem that just assumes everything to be square although QIcon can also hold non-square icons such as the ones coming from the thumbnail generator. Still seeing this in Plasma 5.5.95 :( *** Bug 361634 has been marked as a duplicate of this bug. *** *** Bug 362679 has been marked as a duplicate of this bug. *** Problem exists in a fresh install of ubuntu 16.04 Plasma 5.5.5 Created attachment 98801 [details]
screenshot
Still not fixed in 5.7.2 My wife don't like it and this is bad :-( Hi, I can confirm that (buggy) behavior on Debian testing (currently plasma 5.6.5) -- icon previews are always scaled to squares (ignoring the actual aspect ratio of the particular items). Regards, Gerhard Hi ! I can confirm this issue in Plasma 5.8, Framework 5.26 (KDE Neon image from October). *** Bug 373346 has been marked as a duplicate of this bug. *** Git commit d46a91ea57f19e33e6f3a08ec86084b7e11a8e1a by Kai Uwe Broulik. Committed on 05/01/2017 at 14:15. Pushed by broulik into branch 'master'. [Icon Item] Support non-square icons Differential Revision: https://phabricator.kde.org/D3892 M +39 -0 autotests/iconitemtest.cpp M +1 -0 autotests/iconitemtest.h M +38 -12 src/declarativeimports/core/iconitem.cpp M +1 -0 src/declarativeimports/core/iconitem.h https://commits.kde.org/plasma-framework/d46a91ea57f19e33e6f3a08ec86084b7e11a8e1a wow Thanks for the fix :-) Cool news, thanks! Please, please consider applying this fix to Plasma 5.8 (LTS), too! Please! :-) |