Bug 355508

Summary: Make KAboutData accept https:// next to http:// for schema of homepage URL
Product: [Frameworks and Libraries] frameworks-kcoreaddons Reporter: Martin Walch <walch.martin>
Component: generalAssignee: Michael Pyne <mpyne>
Status: RESOLVED FIXED    
Severity: wishlist CC: kdelibs-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: http://commits.kde.org/kcoreaddons/9e5f731c8f63d239172f76d826973042e7920dee Version Fixed/Implemented In: 5.17
Sentry Crash Report:

Description Martin Walch 2015-11-17 18:30:41 UTC 
API documentation says:

> Start the address with "http://".

and the implementation checks

> if (d->_homepageAddress.contains(QLatin1String("http://"))) {

Considering that more and more of the www is using https:// as primary schema, deprecating plain http://, this should be specified and processed accordingly in KAboutData.  (In particular also *.kde.org defaults to https://)
Comment 1 Michael Pyne 2015-11-27 23:16:38 UTC 
A fix is in the works, see https://git.reviewboard.kde.org/r/126189/
Comment 2 Michael Pyne 2015-12-03 00:38:51 UTC 
Git commit 9e5f731c8f63d239172f76d826973042e7920dee by Michael Pyne.
Committed on 03/12/2015 at 00:37.
Pushed by mpyne into branch 'master'.

KAboutData: Allow https:// and other URL schemas in homepage.

This commit permits URLs such as "https://www.foo.org" (i.e. with
non-http schemas), since we currently require applications to provide
a http:// URL only (a rather obvious misfeature in 2015).
FIXED-IN:5.17
REVIEW:126189

M  +12   -0    autotests/kaboutdatatest.cpp
M  +22   -19   src/lib/kaboutdata.cpp
M  +14   -8    src/lib/kaboutdata.h

http://commits.kde.org/kcoreaddons/9e5f731c8f63d239172f76d826973042e7920dee