| Summary: | Missing icons for plasma-nm | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Jan Grulich <jgrulich> |
| Component: | Theme - Breeze | Assignee: | visual-design |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | andreas_k, benedikt, chemobejk, contact, jgrulich, kainz.a, kde, notmart, plasma-bugs, rdieter, sebas, uri_herrera |
| Priority: | NOR | ||
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Jan Grulich
2015-11-16 08:20:39 UTC
Changing summary, VPN icon is not the only one missing, previously we had a bunch of icons for various modem technologies (edge, gprs, hdspa, etc.). And last thing, why all icons have red padlock while ethernet has it black, which is btw. barely visible. The main problem is that noone tell us to add additional icons for (edge, gprs, hdspa, ...) so if you know the icon name please list all missing icons by name. we will have a look about the visibility. They were all in previous release so you can check it there. I expected you did that before you replaced the old icon pack with the new one. Missing icons: - network-mobile-[0, 20, 40, 60, 80, 100]-[gprs, edge, umts, hsdpa, hsupa, hspa, lte] - network-mobile-[0, 20, 40, 60, 80, 100]-[gprs, edge, umts, hsdpa, hsupa, hspa]-locked - network-mobile-on - network-vpn thanks. we will fix it. I'm experiencing the same problem with missing VPN icons. "kiconfinder5 network-vpn" only finds a 22x22 version of the icon. The modem icons Jan is speaking of are network-mobile-%1 network-mobile-%1-gprs network-mobile-%1-edge network-mobile-%1-umts network-mobile-%1-hsdpa network-mobile-%1-hsupa network-mobile-%1-hspa network-mobile-%1-lte where %1 can be 0, 20, 40, 60, 80, or 100. These are completely missing from my system (cannot be found by kiconfinder5). I also noticed that the systray icon for Amarok is missing. kiconfinder points to a 48x48 version of the icon, which is coloured, unlike the black-and-transparent outline version of the symbol that was there before. The icons for plasma-nm come form the Plasma theme not the icon theme. And yes they are missing. I'll add them. I've added the icons but they don't have the class attribute so they won't change color when using another color scheme. I add marco to the bug report cause he knows the attribute stuff. Perfect, thanks, just add "network-mobile-on" icon. is the latest version just pushed complete? Nope, one icon (network-mobile-on) is still missing. Found one more missing icon → network-wired (used for deactivated ethernet connections), you have only network-wired-[available, unavailable, activated, activated-locked, activated-limited]. hmm, how many icons are there? if it's became hard to even keep track of how many icons that single applet is using, isn't that a symptom of a too complicate design? (perhaps using composed layers like the battery applet would greatly reduce the sheer quantity of individual icons needed) We use quite a lot of icons, because there is also quite a lot of connection types, where some of them can have different signal/technology/state. It's true that most of them could be created from various layers, but right now I don't have time to do that. Ping? Any progress on adding those two missing icons (network-wired, network-mobile-on)? You have just a week or so to get this into KF5 5.17, otherwise it will be broken for users one more month. was included with this commit (https://quickgit.kde.org/?p=plasma-framework.git&a=commit&h=e73a82c168ed2e4c16d6b773c8fd33f693c1f9c2) please check plasma-framework master *** Bug 355529 has been marked as a duplicate of this bug. *** Perfect, the set is now complete, but unfotrunately broken for breeze-dark because it requires to set some attribute or something like that as Uri said in comment 8. should be fixed now Yes, it's fixed finally \o/. Maybe we should ask for a new tarball of plasma-framework which includes this fix. |