Bug 354388

Summary:	Column width in Detailed (Tree) View not remembered, and not auto-sized correctly
Product:	[Frameworks and Libraries] frameworks-kio	Reporter:	Michael D <nortexoid>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, grouchomarx.fr, kde, kdelibs-bugs, nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kio/e504bc1fd56412ee7e9748a0dfafa537977ec1b5	Version Fixed In:	5.46
Sentry Crash Report:
Attachments:	Screenshot of issue

Description Michael D 2015-10-26 09:07:26 UTC

The file picker dialog doesn't remember detailed view column widths manually set by the user, and it doesn't choose an optimal width itself. I would prefer if it chose an optimal width itself, which is what Dolphin seems to do. I've attached a screenshot showing this.

Reproducible: Always

Steps to Reproduce:
1. Invoke file picker dialog
2. Set Detailed (Tree) View as the view option (or perhaps do this first, close file picker, and re-invoke it?)

Actual Results:  
Notice the suboptimal (often terrible) column widths

Expected Results:  
One notices optimal column widths

KF5, plasma and qt version 5.4.2.

Comment 1 Michael D 2015-12-07 16:36:15 UTC

Created attachment 95925 [details]
Screenshot of issue

Comment 2 Michael D 2017-03-20 08:35:39 UTC

I was just about to file another bug report for this, as I forgot I filed one over a year ago. The bug still persists in Frameworks version 5.32.0 (plasma 5.9.3). It would be something of a dream of mine to have it fixed.

Comment 3 kde 2018-04-06 11:47:38 UTC

It's still like this in Frameworks 5.44.0, and I just wanted to report the exact same thing.

Columns should auto-fit in the filepicker like they do in Dolphin, this is something that always irks me.

Comment 4 Nate Graham 2018-04-06 13:17:32 UTC

*** Bug 390947 has been marked as a duplicate of this bug. ***

Comment 5 Michael D 2018-04-09 21:47:02 UTC

This is a duplicate of bug 196508.

Comment 6 Michael D 2018-04-09 23:37:16 UTC


*** This bug has been marked as a duplicate of bug 196508 ***

Comment 7 Nate Graham 2018-04-12 19:43:08 UTC

Git commit e504bc1fd56412ee7e9748a0dfafa537977ec1b5 by Nathaniel Graham, on behalf of Scott Harvey.
Committed on 12/04/2018 at 19:42.
Pushed by ngraham into branch 'master'.

Tweak column widths in tree view of file open/save dialogs

Summary:
Adjust column sizing options so that "last" column is no longer the largest.
First column (folder/file name & icon) will now occupy the majority of the space but does not compress other columns.
Related: bug 338502, bug 196508, bug 177743, bug 96638
FIXED-IN: 5.46

Test Plan:
- Compile KIO with patch
- Recompile an application (i.e. Kate), ensuring it will include the patched version of KIO
- File -> Open (and/or File -> Save); select Detailed Tree View option
- Check that Name column is the widest and occupies most of the space

Reviewers: ngraham, dfaure, #frameworks, broulik

Reviewed By: ngraham, broulik

Subscribers: #dolphin, cfeck, fabiank, broulik

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D11993

M  +4    -53   src/filewidgets/kdiroperatordetailview.cpp
M  +0    -7    src/filewidgets/kdiroperatordetailview_p.h

https://commits.kde.org/kio/e504bc1fd56412ee7e9748a0dfafa537977ec1b5