| Summary: | Renaming a file does not scroll to the selected file | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Nathan Shearer <kde-20091112> |
| Component: | view-engine: general | Assignee: | Konqueror Developers <konq-bugs> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | bugseforuns, elvis.angelaccio, justin.zobel, kde-20091112, nate, null |
| Priority: | NOR | ||
| Version First Reported In: | 17.08.0 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Video
reproducible with files located in a ntfs partition |
||
|
Description
Nathan Shearer
2015-10-25 01:29:12 UTC
Still exists in Dolphin 16.08.3 Annoying usability problem... There are lots of legit usability reasons why you might *not* want this. For example, if you're renaming multiple files in such a manner that they will be re-sorted elsewhere, after each one your view will change, making the multiple-file-rename operation an infuriating experience. macOS finder behaved this way for many years and Apple got a lot of complaints about it, eventually reverting the behavior to match what Dolphin does today. FWIW, there is a patch for this: https://phabricator.kde.org/D6312 Reopening, this should be properly discussed before a wontfix. (see my comment in D6312) Fair enough, I withdraw my objection. Git commit 478f404b8abf924a0e3e21bbf1dd49aefbe47672 by Elvis Angelaccio, on behalf of Emirald Mateli. Committed on 17/09/2017 at 09:12. Pushed by elvisangelaccio into branch 'Applications/17.08'. Keep renamed file(s) in view When renaming a file, if its new name causes it to scroll out of view, Dolphin will not scroll to the location of the new file. This patch aims to address that. This affects all view modes. Test Plan: 1. Have many files in a directory (or several files, just zoom in a lot) 2. Rename a file so that it will move out of view Differential Revision: https://phabricator.kde.org/D6312 M +19 -3 src/views/dolphinview.cpp M +9 -0 src/views/dolphinview.h M +9 -0 src/views/renamedialog.cpp M +4 -0 src/views/renamedialog.h https://commits.kde.org/dolphin/478f404b8abf924a0e3e21bbf1dd49aefbe47672 I'm leaving this bug open because there is still a corner case not fixed by the above patch: 1. rename something so that it goes out of the view 2. dolphin scrolls the view 3. press CTRL+Z 4. dolphin should scroll the view back to the original place but it doesn't. Ideas for a potential patch: https://phabricator.kde.org/D6312#146843 I cannot reproduce on Dolphin 20.08.1, can you please re-test and confirm if this is still an issue. I can reproduce with any view mode on neon unstable. Created attachment 132812 [details]
Video
Interesting that we're both on KDE Neon Unstable but I can't reproduce. Must be a setting or configuration option somewhere.
Created attachment 132830 [details]
reproducible with files located in a ntfs partition
Weirdly I can reproduce this bug with files located in my ntfs partition
but I can't with the ones located in my Home.
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.20.80
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.0
Info was provided; moving back to REPORTED Can confirm with NTFS partition that it does not scroll to newly named file. |