Bug 353928

Summary: Rename "Show/Hide Dashboard" to "Show/Hide Desktop"
Product: [Plasma] plasmashell Reporter: Thomas Pfeiffer <thomas.pfeiffer>
Component: Application Dashboard widgetAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: normal CC: bhush94, chgonzalezg, kde
Priority: NOR    
Version: 5.4.0   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: http://commits.kde.org/kwin/c408e9ccec2579e34f287c911f2d883b7bf9cc6f Version Fixed In:
Sentry Crash Report:

Description Thomas Pfeiffer 2015-10-15 14:57:26 UTC 
The "Show Dashboard" entry in the Plasma menu does the same as the "Show Desktop" Plasmoid or pressing the "Show Desktop" shortcut, yet it is called "Show Dashboard". This rightfully confuses users, as bug 344180 shows.

Therefore, it has to be renamed to reflect what it actually does. If we at some point create an actual Dashboard feature in Plasma 5 (i.e. a new layer with its own set of widgets), we should add an additional Show Dashboard entry to the menu.

A dashboard is not the same thing as the desktop, so we must not confuse the two in the labeling of menu entries.

Reproducible: Always
Comment 1 David Edmundson 2015-10-16 19:12:38 UTC 
KWin has two options in the screen edges KCM

show dashboard and show desktop.

Do they do the same thing?
Comment 2 Thomas Pfeiffer 2015-10-16 19:19:33 UTC 
At least as far as I as a user can tell, the indeed do the same thing. I guess that's a leftover from times when dashboard and show desktop were still different things.
Comment 3 David Edmundson 2015-10-17 12:11:22 UTC 
Git commit 8b9af710630d3624cf2810c36fd9b63be6565d61 by David Edmundson.
Committed on 17/10/2015 at 11:57.
Pushed by davidedmundson into branch 'master'.

Rename show dashboard to show desktop

As that's what it does
REVIEW: 125670

M  +2    -2    shell/shellcorona.cpp

http://commits.kde.org/plasma-workspace/8b9af710630d3624cf2810c36fd9b63be6565d61
Comment 4 David Edmundson 2015-10-17 12:12:19 UTC 
Not closed yet as I need to make a change in the kwin KCM
Comment 5 Martin Flöser 2015-10-21 06:15:19 UTC 
Git commit c408e9ccec2579e34f287c911f2d883b7bf9cc6f by Martin Gräßlin.
Committed on 21/10/2015 at 06:12.
Pushed by graesslin into branch 'master'.

Drop remaning code for ShowDashboard

Removes the ElectricAction for ShowDashboard and the relevant code
in screenedges and the KCM.

Also a leftover in the glide effect.

REVIEW: 125700

M  +1    -2    effects/glide/glide.cpp
M  +1    -1    kcmkwin/kwincompositing/kcmkwineffects.desktop
M  +9    -13   kcmkwin/kwinscreenedges/main.cpp
M  +0    -1    libkwineffects/kwinglobals.h
M  +1    -8    screenedge.cpp

http://commits.kde.org/kwin/c408e9ccec2579e34f287c911f2d883b7bf9cc6f