Summary: | Moving/copying by drag n' drop between dolphin windows does not respect pressed Ctrl/shift | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | d_tassos |
Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
Status: | CLOSED UPSTREAM | ||
Severity: | normal | CC: | chris.rapson, codestruct, crgridley, daniel.eckl, emmanuelpescosta099, gladhorn, illumilore, inghamn, j.k, rapiteanu.catalin, rich.trefz |
Priority: | NOR | ||
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | Qt 5.6.3/5.7.1 |
Description
d_tassos
2015-09-02 20:55:50 UTC
Thanks for the bug report, I can reproduce the problem! After some debugging and digging around in KIO DropJob, I am 100% sure that the bug is in Qt (see https://bugreports.qt.io/browse/QTBUG-894). KIO DropJob uses the proposed drop action only when modifier keys were set (because Qt defaults to copy when no modifiers were present), if no modifiers were set KIO DropJob will ask the user. With this Qt Bug the modifier keys are always empty (= NoModifier) and so KIO always opens the popup, even when the right drop action was proposed by Qt. I have added some debug output to KItemListController::dropEvent: * Drop with shift pressed: org.kde.dolphin: KItemListController::dropEvent QFlags<Qt::KeyboardModifiers>(NoModifier) Qt::DropAction(Movion) * Drop with ctrl pressed: org.kde.dolphin: KItemListController::dropEvent QFlags<Qt::KeyboardModifiers>(NoModifier) Qt::DropAction(Copion) * Drop without a modifier key: org.kde.dolphin: KItemListController::dropEvent QFlags<Qt::KeyboardModifiers>(NoModifier) Qt::DropAction(Copion) *** Bug 352592 has been marked as a duplicate of this bug. *** I thought it was this bug? https://bugreports.qt.io/browse/QTBUG-48795 QTBUG-48795 is about synthetic key events and does not change the behaviour when it comes to drag and drop. If someone could test https://codereview.qt-project.org/#/c/171148/ that would be appreciated. I'll probably not get around to it in the next few days. Actually it seems to work for me. Fix will be in Qt 5.6.3/5.7.1. *** Bug 373510 has been marked as a duplicate of this bug. *** *** Bug 346663 has been marked as a duplicate of this bug. *** *** Bug 307083 has been marked as a duplicate of this bug. *** I assume this can be closed now. |