| Summary: | Restart/Reboot naming isn't consistent | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nick <npaulin> |
| Component: | Application Menu (Kicker) | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | kde, kdebugs, plasma-bugs, sudhir |
| Priority: | NOR | ||
| Version: | 5.3.2 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Chakra | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/16bc876686625984842e017e9ee0c516e7f59d00 | Version Fixed In: | |
| Sentry Crash Report: | |||
Good catch. David, which do you prefer? While you're at it, please fix "Shutdown" and "Shut down". In English, "shutdown" is considered a noun, while "shut down" is the verb phrase. Thus, if you "shut it down" twice, that's two "shutdowns". In KDE4, the menu has it right: "Shut down", but the Alt-F2 launcher has it wrong: "Shutdown the computer". The pop-up uses "Turning off the computer in 29 seconds." which is ok with me. In KDE5, the menu has it wrong: "Shutdown", as does the Alt-F2 launcher: "Shutdown the computer". The pop-up uses "Shutting down" which is fine. ^ Good feedback, thanks! Hi Eike, Is naming scheme Suspend to RAM for Suspend and Suspend to Disk for Hibernate is intentional? AppDash, Kicker, and Kickoff use Suspend for Suspend to RAM and Hibernate to Suspend to Disk. Why are we not using same names for KRunner? Thanks. I'd suggest asking the VDG for input and then submitting patches. Leaving the link to the thread I created a few days ago. https://forum.kde.org/viewtopic.php?f=285&t=132369 >Good catch. David, which do you prefer?
(I may not be the fastest to reply, but I get there in the end)
Reboot.
Restart has the potential to be vague (restart what?).
Whereas reboot heavily implies hardware.
I've patched the shutdown strings already. I'll do this reboot one too.
The suspend thing is more of a different issue that I'll leave to the forum. I think we're at least consistent there.
Git commit 7f1e656923218fc81a5a8a326128f38b9aaab1c4 by David Edmundson. Committed on 04/05/2016 at 11:38. Pushed by davidedmundson into branch 'master'. Fix usage of string "shut down" Some say shutdown, some say shut down. REVIEW: 127792 M +1 -1 daemon/actions/bundled/handlebuttoneventsconfig.cpp M +1 -1 daemon/actions/bundled/suspendsessionconfig.cpp M +1 -1 kcmodule/activities/activitywidget.cpp M +1 -1 kcmodule/global/GeneralPage.cpp http://commits.kde.org/powerdevil/7f1e656923218fc81a5a8a326128f38b9aaab1c4 Git commit dd67a42cd5170c73ad50c4a0e9ccf6dfd0aa30e9 by David Edmundson. Committed on 04/05/2016 at 11:51. Pushed by davidedmundson into branch 'master'. Fix usage of string "shutdown" and "restart" Some say shutdown, some say shut down. We want reboot consistently instead of restart (when talking about the computer) REVIEW: 127790 M +2 -2 applets/kicker/plugin/systementry.cpp http://commits.kde.org/plasma-desktop/dd67a42cd5170c73ad50c4a0e9ccf6dfd0aa30e9 Git commit 16bc876686625984842e017e9ee0c516e7f59d00 by David Edmundson. Committed on 04/05/2016 at 15:48. Pushed by davidedmundson into branch 'master'. Fix usage of string "shut down" Some say shutdown, some say shut down. REVIEW: 127791 M +1 -1 lookandfeel/contents/components/LogoutOptions.qml http://commits.kde.org/plasma-workspace/16bc876686625984842e017e9ee0c516e7f59d00 |
The option to restart the computer in the menu is: Power/Session -> Restart The graphical notification bar indicating the restart in 30 seconds reads ... Reboot Is there a reason the word changed? I know this is minor... really minor.. but it feels inconsistent. Reproducible: Always