Summary: | Add/remove buttons remain visible after using Desktop grid effect | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Jure Repinc <jlp> |
Component: | effects-window-management | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andreas_k |
Priority: | NOR | Flags: | thomas.luebking:
ReviewRequest+
|
Version: | git master | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/124970/ | ||
Latest Commit: | http://commits.kde.org/kwin/584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d | Version Fixed In: | 5.4.2 |
Description
Jure Repinc
2015-08-27 17:11:07 UTC
Can you try to apply this patch: https://git.reviewboard.kde.org/r/124888/ Git commit 9139cca72c5612482c8c27e70196d583630772af by Thomas Lübking. Committed on 27/08/2015 at 20:21. Pushed by luebking into branch 'Plasma/5.4'. never trigger edges during the cooldown regardless of whether the pushback is forced down or the user has deactivated it or whatever. The edge is waiting from previous activation and we need to prevent immediate reactivation since that may cause duplicate action and unwanted state toggles Related: bug 351627 FIXED-IN: 5.4.1 REVIEW: 124888 M +4 -0 screenedge.cpp http://commits.kde.org/kwin/9139cca72c5612482c8c27e70196d583630772af Nope, there's more to it. Fixing patch: https://git.reviewboard.kde.org/r/124970/ Sorry for the trouble. Hi, The VDG is focus on an consistent design for plasma and we are also looking into the Desktop Grid Effect. Here you get the information how it should work in general: http://user-prompt.com/look-and-feel-of-plasma-sidebars/ So the idea is for the desktop grid effect that you have an Title on top that the user know it's the destkop grid than above the desktop previews and on bottom an panel for global actions e.g. remove last desktop, add new desktop, ... future things The thing is that it is really nice that the user can add desktops without using SystemSettings. And if you get the same behaviour in ALL Plasma views it would be better to understand. e.g. in the Grid View noone knows what the plus and delete button are used for because there is no tooltop or label. Would it be a way you would like to go or do I don't understand your problem. Andreas, this is a technical bug. Because creating QtQuick views is *incredibly* slow, we now keep and "hide" them by moving them out of sight. Unfortunately this introduced a bunch of follow-up bugs. One of them is that the view is "forgotten" in some cases (this bug, fix linked in comment #3) It is *not* a design complaint. PS: bug #352588 may better fit your efforts thanks Thomas. That's the reason why I don't understand the bug. good to know. Thanks Git commit 584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d by Thomas Lübking. Committed on 14/09/2015 at 19:01. Pushed by luebking into branch 'Plasma/5.4'. ensure to "hide" desktop buttons before, hiding the buttons relied on the effect seeing a paint event for the (with a low timeline value) what's too wonky at least for instant animations (certain failure) or when effect exits immediatey (due to screen edge invocation issues or whatever) FIXED-IN: 5.4.2 REVIEW: 124970 M +10 -0 effects/desktopgrid/desktopgrid.cpp http://commits.kde.org/kwin/584850f1604ceff0cd8e3cd5f6b16b2c5c4d0c6d |