| Summary: | pto2mk not found with Hugin 2015.0 | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Benjamin Girault <benjamin.girault> |
| Component: | Plugin-Generic-Panorama | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | axel.krebs, caulier.gilles, dirk.van.aken, frode, gm.kde.org, linux, luca.bs, peters-kdebugs, philippe.quaglia |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/digikam/1a5a6ea49710bed310875900814be70744385aa5 | Version Fixed In: | 5.0.0 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot from DigiKam 5.1.0 Win 64 bits still requiring pto2mk.exe | ||
|
Description
Benjamin Girault
2015-08-18 11:11:36 UTC
Benjamin, I tried to use Hugin 2014 without success. It's installed by default into Mageia. None pano can be generated properly. There are several make issues while preview rendering. I tried to regenerate older pano done with 2013. Uninstalling 2014 and recompiling and installing 2013 fix all problem. So 2014 cannot be the solution. Gilles As you said, this is a problem with make, not with pto2mk. Please file a different bug report for your issue, this one is about pto2mk not found (and meant as a reminder for me). Also, I cannot help at all without a better description of the issue such as the console output (again, in another bug report). *** Bug 353131 has been marked as a duplicate of this bug. *** *** Bug 353457 has been marked as a duplicate of this bug. *** *** Bug 354725 has been marked as a duplicate of this bug. *** *** Bug 359107 has been marked as a duplicate of this bug. *** Git commit 1a5a6ea49710bed310875900814be70744385aa5 by Gilles Caulier. Committed on 21/02/2016 at 10:57. Pushed by cgilles into branch 'master'. PAnorama tool integration to digiKam core. Tested with JPEG pano using Hugin 2015.0. Work perfectly. Nedd to perform regression test with RAW files. Stand alone version restored into core/test/assistants. Related: bug 325830 FIXED-IN: 5.0.0 M +8 -1 CMakeLists.txt M +18 -4 app/CMakeLists.txt M +16 -0 app/main/digikamapp.cpp M +1 -0 app/main/digikamapp.h M +2 -0 app/main/digikamapp_p.h M +2 -1 app/main/digikamui.rc M +1 -0 data/icons/CMakeLists.txt A +- -- data/icons/panorama/128-apps-kipi-panorama.png A +- -- data/icons/panorama/16-apps-kipi-panorama.png A +- -- data/icons/panorama/22-apps-kipi-panorama.png A +- -- data/icons/panorama/32-apps-kipi-panorama.png A +- -- data/icons/panorama/48-apps-kipi-panorama.png A +- -- data/icons/panorama/96-apps-kipi-panorama.png A +15 -0 data/icons/panorama/CMakeLists.txt A +- -- data/icons/panorama/sc-apps-kipi-panorama.svgz M +1 -0 data/pics/CMakeLists.txt A +- -- data/pics/assistant-hugin.png M +44 -9 tests/assistants/CMakeLists.txt A +44 -0 tests/assistants/panoparser_test.cpp [License: GPL (v2+)] A +66 -0 tests/assistants/panorama.cpp [License: GPL (v2+)] M +4 -0 utilities/assistants/CMakeLists.txt M +1 -1 utilities/assistants/common/dprogresswdg.cpp A +77 -0 utilities/assistants/panorama/CMakeLists.txt A +34 -0 utilities/assistants/panorama/README A +285 -0 utilities/assistants/panorama/importwizard/panointropage.cpp [License: GPL (v2+)] A +74 -0 utilities/assistants/panorama/importwizard/panointropage.h [License: GPL (v2+)] A +122 -0 utilities/assistants/panorama/importwizard/panoitemspage.cpp [License: GPL (v2+)] A +66 -0 utilities/assistants/panorama/importwizard/panoitemspage.h [License: GPL (v2+)] A +332 -0 utilities/assistants/panorama/importwizard/panolastpage.cpp [License: GPL (v2+)] A +74 -0 utilities/assistants/panorama/importwizard/panolastpage.h [License: GPL (v2+)] A +375 -0 utilities/assistants/panorama/importwizard/panooptimizepage.cpp [License: GPL (v2+)] A +73 -0 utilities/assistants/panorama/importwizard/panooptimizepage.h [License: GPL (v2+)] A +369 -0 utilities/assistants/panorama/importwizard/panopreprocesspage.cpp [License: GPL (v2+)] A +72 -0 utilities/assistants/panorama/importwizard/panopreprocesspage.h [License: GPL (v2+)] A +632 -0 utilities/assistants/panorama/importwizard/panopreviewpage.cpp [License: GPL (v2+)] A +79 -0 utilities/assistants/panorama/importwizard/panopreviewpage.h [License: GPL (v2+)] A +131 -0 utilities/assistants/panorama/importwizard/panowizard.cpp [License: GPL (v2+)] A +54 -0 utilities/assistants/panorama/importwizard/panowizard.h [License: GPL (v2+)] A +60 -0 utilities/assistants/panorama/manager/autooptimiserbinary.h [License: GPL (v2+)] A +57 -0 utilities/assistants/panorama/manager/cpcleanbinary.h [License: GPL (v2+)] A +60 -0 utilities/assistants/panorama/manager/cpfindbinary.cpp [License: GPL (v2+)] A +70 -0 utilities/assistants/panorama/manager/cpfindbinary.h [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/manager/enblendbinary.h [License: GPL (v2+)] A +58 -0 utilities/assistants/panorama/manager/huginexecutorbinary.h [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/manager/makebinary.h [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/manager/nonabinary.h [License: GPL (v2+)] A +118 -0 utilities/assistants/panorama/manager/panoactions.h [License: GPL (v2+)] A +510 -0 utilities/assistants/panorama/manager/panoactionthread.cpp [License: GPL (v2+)] A +118 -0 utilities/assistants/panorama/manager/panoactionthread.h [License: GPL (v2+)] A +607 -0 utilities/assistants/panorama/manager/panomanager.cpp [License: GPL (v2+)] A +140 -0 utilities/assistants/panorama/manager/panomanager.h [License: GPL (v2+)] A +57 -0 utilities/assistants/panorama/manager/panomodifybinary.h [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/manager/pto2mkbinary.h [License: GPL (v2+)] A +1100 -0 utilities/assistants/panorama/ptoparser/panoParser.y [License: GPL (v2+)] A +333 -0 utilities/assistants/panorama/ptoparser/panoScanner.l [License: GPL (v2+)] A +438 -0 utilities/assistants/panorama/ptoparser/ptofile.cpp [License: GPL (v2+)] A +59 -0 utilities/assistants/panorama/ptoparser/ptofile.h [License: GPL (v2+)] A +229 -0 utilities/assistants/panorama/ptoparser/tparser.c [License: GPL (v2+)] A +232 -0 utilities/assistants/panorama/ptoparser/tparser.h [License: GPL (v2+)] A +42 -0 utilities/assistants/panorama/ptoparser/tparserdebug.h [License: GPL (v2+)] A +965 -0 utilities/assistants/panorama/ptoparser/tparsergetters.c [License: GPL (v2+)] A +166 -0 utilities/assistants/panorama/ptoparser/tparsergetters.h [License: GPL (v2+)] A +244 -0 utilities/assistants/panorama/ptoparser/tparserprivate.c [License: GPL (v2+)] A +49 -0 utilities/assistants/panorama/ptoparser/tparserprivate.h [License: GPL (v2+)] A +401 -0 utilities/assistants/panorama/ptotype/ptotype.cpp [License: GPL (v2+)] A +271 -0 utilities/assistants/panorama/ptotype/ptotype.h [License: GPL (v2+)] A +72 -0 utilities/assistants/panorama/tasks/autocroptask.cpp [License: GPL (v2+)] A +56 -0 utilities/assistants/panorama/tasks/autocroptask.h [License: GPL (v2+)] A +107 -0 utilities/assistants/panorama/tasks/commandtask.cpp [License: GPL (v2+)] A +66 -0 utilities/assistants/panorama/tasks/commandtask.h [License: GPL (v2+)] A +70 -0 utilities/assistants/panorama/tasks/compilemksteptask.cpp [License: GPL (v2+)] A +59 -0 utilities/assistants/panorama/tasks/compilemksteptask.h [License: GPL (v2+)] A +63 -0 utilities/assistants/panorama/tasks/compilemktask.cpp [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/tasks/compilemktask.h [License: GPL (v2+)] A +220 -0 utilities/assistants/panorama/tasks/copyfilestask.cpp [License: GPL (v2+)] A +64 -0 utilities/assistants/panorama/tasks/copyfilestask.h [License: GPL (v2+)] A +66 -0 utilities/assistants/panorama/tasks/cpcleantask.cpp [License: GPL (v2+)] A +54 -0 utilities/assistants/panorama/tasks/cpcleantask.h [License: GPL (v2+)] A +70 -0 utilities/assistants/panorama/tasks/cpfindtask.cpp [License: GPL (v2+)] A +54 -0 utilities/assistants/panorama/tasks/cpfindtask.h [License: GPL (v2+)] A +75 -0 utilities/assistants/panorama/tasks/createfinalptotask.cpp [License: GPL (v2+)] A +54 -0 utilities/assistants/panorama/tasks/createfinalptotask.h [License: GPL (v2+)] A +83 -0 utilities/assistants/panorama/tasks/createmktask.cpp [License: GPL (v2+)] A +56 -0 utilities/assistants/panorama/tasks/createmktask.h [License: GPL (v2+)] A +119 -0 utilities/assistants/panorama/tasks/createpreviewtask.cpp [License: GPL (v2+)] A +61 -0 utilities/assistants/panorama/tasks/createpreviewtask.h [License: GPL (v2+)] A +220 -0 utilities/assistants/panorama/tasks/createptotask.cpp [License: GPL (v2+)] A +65 -0 utilities/assistants/panorama/tasks/createptotask.h [License: GPL (v2+)] A +84 -0 utilities/assistants/panorama/tasks/huginexecutortask.cpp [License: GPL (v2+)] A +55 -0 utilities/assistants/panorama/tasks/huginexecutortask.h [License: GPL (v2+)] A +78 -0 utilities/assistants/panorama/tasks/optimisationtask.cpp [License: GPL (v2+)] A +56 -0 utilities/assistants/panorama/tasks/optimisationtask.h [License: GPL (v2+)] A +58 -0 utilities/assistants/panorama/tasks/panotask.cpp [License: GPL (v2+)] A +65 -0 utilities/assistants/panorama/tasks/panotask.h [License: GPL (v2+)] A +40 -0 utilities/assistants/panorama/tasks/panotasks.h [License: GPL (v2+)] A +225 -0 utilities/assistants/panorama/tasks/preprocesstask.cpp [License: GPL (v2+)] A +70 -0 utilities/assistants/panorama/tasks/preprocesstask.h [License: GPL (v2+)] M +3 -0 utilities/kdesupport/kipi/kipipluginloader.cpp http://commits.kde.org/digikam/1a5a6ea49710bed310875900814be70744385aa5 Dear all, Please bear with me, this is my first comment and I may have missed the obvious. The bug above is marked as resolved and fixed for digiKam 5.0.0. Would this be automatically carried forward to the Windows version (64 bit)? Because as of digiKam 5.1.0, pto2mk.exe is still required in the "Welcome to Panorama Tool" dialog. Does this require a different bug report? Best regards and thanks for all your work with digiKam (found the tool about 2 weeks ago) Gerald yes it is. You must to install Hugin on your computer of course. Created attachment 100979 [details]
Screenshot from DigiKam 5.1.0 Win 64 bits still requiring pto2mk.exe
Oops, the previous attachment went without the comment. Hugin 2016 has been installed and as of Hugin 2015 (and as stated above), pto2mk.exe is no longer included. It still shows up as a required component in DigiKam 5.1.0. under Win64 bits. No it isn't required. However, to ensure compatibility with older versions of Hugin, its detection can still be performed. It works as follows: first the detection of autooptimiser until pano_modify is performed. Then based, on the version of autooptimiser (>= 2015.0 or not), either hugin_executor or pto2mk is detected. For you, two possibilities: - You are not running panorama >= 5.0 (unlikely according to your comment, but we cannot check that on the screenshot) - Something weird is happening and the version check of autooptimiser is not working (but I have the same displayed version of autooptimiser on my Linux computer and it works). Gilles: can you check that? I have a lot of work right now, and not a lot of time. Relevant functions are DBinaryIface::versionIsRight, PanoManager::checkForHugin2015 and PanoIntroPage::PanoIntroPage. Gilles and Benjamin, thanks very much for your quick replies! I closed the panorama dialog window with "Cancel", and out of curiosity re-opened it and now it does show "hugin_excecutor.exe" (without version information however) instead of pto2mk.exe! That's good news. So when I clicked the "Find" button for the "autooptimizer.exe" and selected the file in the file dialog, that's when it did not switch to hugin_executor.exe (however, everything else except for the "make" switched and showed the version number automatically). So this is very minor once one knows the work-around (close and re-open the window). Thanks, Gerald |