Summary: | Table view shows wrong thumbnails [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | DrSlony <bugs> |
Component: | Albums-TableView | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugs, caulier.gilles, metzpinguin |
Priority: | NOR | ||
Version: | 4.12.0 | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/digikam/523b4baf62a354c06086d8825940964efaea0c55 | Version Fixed In: | 4.13.0 |
Attachments: |
tableview.png
tableviewthumbs.patch tableviewthumbs2.patch |
Description
DrSlony
2015-08-13 09:08:08 UTC
Maik, I identified where the problem is with this file : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/app/views/tableview/tableview_column_thumbnail.cpp#L121 Look like only landscape image sizes are supported, not portrait. Fix will be easy to do i think... Gilles Created attachment 94109 [details]
tableview.png
I have not yet looked into the source code. But I see no error in the representation of landscape or portrait photos. See the screenshot.
Maik
Maik, To reproduce the problem, play with thumbnail column size of table view and change thumbnail size with status-bar slider. I can reproduce the problem described by DrSlony. Note : create an album with portrait AND landscape images. Gilles Created attachment 94137 [details]
tableviewthumbs.patch
Gilles, please test this patch.
Maik
Excelent. With this patch, digiKam work like a charm now... Congratulations... Gilles Created attachment 94139 [details]
tableviewthumbs2.patch
Only small code optimization.
Maik
Git commit 523b4baf62a354c06086d8825940964efaea0c55 by Maik Qualmann. Committed on 20/08/2015 at 18:46. Pushed by mqualmann into branch 'master'. apply patch #94139 to correct thumbnails scale in the table view FIXED-IN: 4.13.0 M +2 -1 NEWS M +6 -12 app/views/tableview/tableview_column_thumbnail.cpp http://commits.kde.org/digikam/523b4baf62a354c06086d8825940964efaea0c55 Git commit 3084138b072cd51acb27edd4a70aedbeba0ffd9f by Gilles Caulier. Committed on 20/08/2015 at 20:34. Pushed by cgilles into branch 'frameworks'. apply patch #523b4baf62a354c06086d8825940964efaea0c55 from git/master to frameworks branch M +8 -13 app/views/tableview/tableview_column_thumbnail.cpp http://commits.kde.org/digikam/3084138b072cd51acb27edd4a70aedbeba0ffd9f |