| Summary: | Build script incorrectly detects Taglib version 1.10.0 as lower than 1.7 | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Omar Plummer <omarplummer> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | omarplummer, trufanovan |
| Priority: | NOR | ||
| Version: | 2.8-git | ||
| Target Milestone: | 2.9 | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/amarok/fec8817c530ce42b6485fdabff6051784b8d9904 | Version Fixed In: | |
| Sentry Crash Report: | |||
Could you please submit this to reviewboard.kde.org and subscribe the group Amarok to it? Thank you. Done I should probably reference the review request here: https://git.reviewboard.kde.org/r/124639/ Thank you. Do you have commit rights on KDE repos? You're welcome. No, I do not have commit rights. Git commit fec8817c530ce42b6485fdabff6051784b8d9904 by Konrad Zemek, on behalf of Omar Plummer. Committed on 06/08/2015 at 22:24. Pushed by kzemek into branch 'master'. Fix TagLib version check. The version check compared version strings lexicographically, so "1.7" (the min version) compared as greater than "1.10.0". REVIEW: 124639 M +3 -3 cmake/modules/FindTaglib.cmake http://commits.kde.org/amarok/fec8817c530ce42b6485fdabff6051784b8d9904 *** Bug 368304 has been marked as a duplicate of this bug. *** |
Build fails with the following error: -- TagLib version too old: version searched :1.7, found 1.10.0 The following change allows the build to proceed: diff --git a/cmake/modules/FindTaglib.cmake b/cmake/modules/FindTaglib.cmake index 76b83ac..0c0cd4b 100644 --- a/cmake/modules/FindTaglib.cmake +++ b/cmake/modules/FindTaglib.cmake @@ -29,10 +29,10 @@ if(TAGLIBCONFIG_EXECUTABLE) exec_program(${TAGLIBCONFIG_EXECUTABLE} ARGS --version RETURN_VALUE _return_VALUE OUTPUT_VARIABLE TAGLIB_VERSION) - if(TAGLIB_VERSION STRLESS "${TAGLIB_MIN_VERSION}") + if(TAGLIB_VERSION VERSION_LESS "${TAGLIB_MIN_VERSION}") message(STATUS "TagLib version too old: version searched :${TAGLIB_MIN_VERSION}, found ${TAGLIB_VERSION}") set(TAGLIB_FOUND FALSE) - else(TAGLIB_VERSION STRLESS "${TAGLIB_MIN_VERSION}") + else(TAGLIB_VERSION VERSION_LESS "${TAGLIB_MIN_VERSION}") exec_program(${TAGLIBCONFIG_EXECUTABLE} ARGS --libs RETURN_VALUE _return_VALUE OUTPUT_VARIABLE TAGLIB_LIBRARIES)