Bug 350225

Summary:	Auto rename on import does not work for RAW images
Product:	[Applications] digikam	Reporter:	Mick Sulley <mick>
Component:	AdvancedRename-Import	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	metzpinguin, mick
Priority:	NOR
Version:	4.11.0
Target Milestone:	---
Platform:	Mint (Ubuntu based)
OS:	Linux
Latest Commit:	http://commits.kde.org/digikam/2cbd005028bd12d23bc5784ac4f6a4b95adf04b1	Version Fixed In:	4.13.0
Sentry Crash Report:

Description Mick Sulley 2015-07-14 21:46:32 UTC

When I import RAW images the rename feature does not work.  The settings are -
Customise PIC[date]
Auto-creation of Albums with Extension-based sub-albums ticked. 

This is with a Canon EOS 550D.  If I set it to take jpeg import rename works fine.  If I set it to RAW it does not rename, if I set it to RAW and jpeg it does not rename either.  The pictures do go into the correct sub-album.

Reproducible: Always

Steps to Reproduce:
1.Set camera to take RAW
2.Set auto rename
3.Import

Actual Results:  
Pictures are imported with the native IMG_1234.CR2 file name

Expected Results:  
Pictures are imported renamed as PIC20150714T224244.CR2 format

I don't know if this is specific to the camera, I only have the one camera that will take RAW.
Once the import has finished selecting all and using the rename function works fine, just not auto rename on import.

Comment 1 Maik Qualmann 2015-08-11 17:20:29 UTC

digiKam 4.12.0 have been released.

Can you reproduce the problem with this release ?

Maik

Comment 2 Mick Sulley 2015-08-14 16:21:40 UTC

Sorry for the delay, I was away.  Yes just retested on 4.12.0 and it is still the same.  Are there any other tests I can do to help narrow this down?

Comment 3 Maik Qualmann 2015-08-14 19:43:06 UTC

I've done some tweaking in import of digikam 4.12.0. It is here at the moment not to reproduce. If you select the images in the icon view, RAW-images are then renamed correct? After download not? What if they do not use extension based sub-albums?

Maik

Comment 4 Mick Sulley 2015-08-14 20:28:36 UTC

Yes the problem is still there if I disable extension based sub-albums.  However I also tried disabling 'Use default target album' and then I have to specify the album for the download, but it does rename correctly.  I then tried again with extension based sub-albums enabled and it created the sub-album, downloaded and renamed the picture correctly, so the problem seems to be caused by having a default download album.

I have just noticed something else, if I highlight a group of pictures and rename it works as expected, however if I just highlight a single picture the rename suggestion is the current name, I don't know if that is relevant to this problem.

Comment 5 Maik Qualmann 2015-08-16 18:47:17 UTC

Git commit 2cbd005028bd12d23bc5784ac4f6a4b95adf04b1 by Maik Qualmann.
Committed on 16/08/2015 at 18:36.
Pushed by mqualmann into branch 'master'.

Fix set new download name from import tool when use a default target album
Related: bug 346646
FIXED-IN: 4.13.0

M  +3    -1    NEWS
M  +14   -3    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/2cbd005028bd12d23bc5784ac4f6a4b95adf04b1

Comment 6 Mick Sulley 2015-08-16 19:07:08 UTC

Thanks, I will test when I have access to 4.13.0

Comment 7 caulier.gilles 2015-08-18 20:59:34 UTC

Git commit 0e1dab213c77acd103f49a9afa6452d4226ffc66 by Gilles Caulier.
Committed on 18/08/2015 at 20:58.
Pushed by cgilles into branch 'frameworks'.

backport commit #2cbd005028bd12d23bc5784ac4f6a4 from git/master to frameworks branch
Related: bug 346646

M  +14   -5    utilities/importui/main/importui.cpp

http://commits.kde.org/digikam/0e1dab213c77acd103f49a9afa6452d4226ffc66

Comment 8 Mick Sulley 2015-09-09 15:31:13 UTC

4.13.0 has made it through to Linux Mint, I have tested and the fix works fine.

Thanks you