Bug 349789

Summary:	Local Folders Disappear when Last Search Deleted
Product:	[Applications] kmail2	Reporter:	TimJH <bin>
Component:	folders	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alvarenga, faure, rigo, thiago.bauermann
Priority:	NOR
Version:	4.14.1
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	http://commits.kde.org/kitemmodels/e2a688651cc5fb3cca682c4153866609713e76a9	Version Fixed In:	5.25
Sentry Crash Report:
Attachments:	Screenshot

Description TimJH 2015-07-01 16:46:54 UTC

When I delete a Search Results folder KMail loses all the Local Folders. Close/restart of KMail restores them.

Running Kuntu 14.10 64bit in a virtual machine (Virtual Box Guest under Win7 Host). 

Reproducible: Always

Steps to Reproduce:
1.Do a Find Messages search
2.Look at result folder
3.Delete Last Search folder

Actual Results:  
All Local Folders disappear

Expected Results:  
Just the one folder disappears

They're not lost.  Restart  KMail and they're back.  That's a clunky workaround.  Just leaving a Last Search folder is the easier workaround, but I'm in the habit of deleting old searches, and other users might panic.

Comment 1 André Marcelo Alvarenga 2016-01-30 18:42:37 UTC

Created attachment 96930 [details]
Screenshot

I can reproduce this bug with KMail 5.1.1. See screenshot.

Comment 2 David Faure 2016-07-12 07:55:48 UTC

*** Bug 341746 has been marked as a duplicate of this bug. ***

Comment 3 David Faure 2016-07-12 07:56:23 UTC

*** Bug 346280 has been marked as a duplicate of this bug. ***

Comment 4 David Faure 2016-07-22 22:10:19 UTC

Git commit e2a688651cc5fb3cca682c4153866609713e76a9 by David Faure.
Committed on 22/07/2016 at 22:09.
Pushed by dfaure into branch 'master'.

KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

If the row being removed from the source model isn't shown by KRFPM,
it's correct that we don't need to emit any signals, however we still
need to tell our base class QSFPM so that it updates the mappings
of the visible siblings below that removed row.

Testcase: deleting the Last Search folder in kmail
(full integration test for this testcase will be added to mailcommon).

REVIEW: 128428
FIXED-IN: 5.25

M  +3    -1    autotests/krecursivefilterproxymodeltest.cpp
M  +0    -20   src/krecursivefilterproxymodel.cpp

http://commits.kde.org/kitemmodels/e2a688651cc5fb3cca682c4153866609713e76a9

Comment 5 David Faure 2016-10-28 09:12:12 UTC

Git commit e58d4813b9eb6125bad83cc4fd576d5d75d31c4b by David Faure.
Committed on 28/10/2016 at 09:11.
Pushed by dfaure into branch 'KDE/4.14'.

KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

Backported from e2a6886 in kitemmodels.

If the row being removed from the source model isn't shown by KRFPM,
it's correct that we don't need to emit any signals, however we still
need to tell our base class QSFPM so that it updates the mappings
of the visible siblings below that removed row.

Testcase: deleting the Last Search folder in kmail
(full integration test for this testcase will be added to mailcommon).

REVIEW: 128428

M  +0    -26   kdeui/itemviews/krecursivefilterproxymodel.cpp
M  +3    -1    kdeui/tests/krecursivefilterproxymodeltest.cpp

http://commits.kde.org/kdelibs/e58d4813b9eb6125bad83cc4fd576d5d75d31c4b