Bug 349402

Summary: Selecting more than 6 images to view causes strange behavior
Product: [Applications] gwenview Reporter: Anthony Chiporo <chiporo>
Component: generalAssignee: Gwenview Bugs <gwenview-bugs-null>
Status: REOPENED ---    
Severity: normal CC: h.klene, jaham, justin.zobel, mahen, myriam, nate, null
Priority: NOR    
Version First Reported In: 17.08.2   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
URL: https://drive.google.com/file/d/0Bzox7uNCpkD3RXJ1akdxeTQ3LVU/view?usp=sharing
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Anthony Chiporo 2015-06-20 01:31:57 UTC
After selecting more than six images in the "Browse" window and clicking "View", only six of the selected images will be displayed. After deleting or unselecting one of the images, each one of the images not initially shown will appear in the center of the screen until each is either deleted or unselected.

Reproducible: Always

Steps to Reproduce:
1. Select more than 6 images
2. Click View
3. Unselect or delete one of the images
Comment 1 Nate Graham 2017-09-09 01:43:32 UTC
I have to imagine that this is the intended behavior, though I agree it's a bit odd, and probably not exactly what folks would expect.
Comment 2 null 2017-11-01 00:05:38 UTC
*** Bug 386405 has been marked as a duplicate of this bug. ***
Comment 3 Mahendra Tallur 2017-11-01 08:25:07 UTC
Hi ! 
ACcually, I'm not personally sure this was the expected behaviour (maybe I could ask Aurélien).

I think the comparison feature should either :
- limit the selection to 6 pics
- or display a mosaic with as many lines / coolumns as required
- or "queue" the 7th, 8th etc pics, not display them until some pics are unselected, and replace the unselected ones with them

but inconsistently putting one in the middle does not make too much sense IMHO :)

Great feature & awesome app btw :)
Comment 4 Mahendra Tallur 2017-11-01 08:31:19 UTC
(sorry for the typos, typing with a crying baby in my arms...)
BTW as I filed a duplicate by mistake, is it possible to specify on this bugreport that the bug occurs with the latest KDE Apps 17.08.2 ?
Cheers !
Comment 5 null 2017-11-01 23:45:47 UTC
No worries, Mahendra, the duplicate was no problem at all. Version is updated now.

I stumbled upon this strange behaviour myself already and I agree with your analysis. As you seem to use the feature, could you expand a bit on your usage scenario? This way, it would be easier for some developer reading the bug to decide where to put the upper limit on the number of images (or whether going with the other options would make more sense).
Comment 6 Mahendra Tallur 2017-11-02 07:39:57 UTC
Hi ! 

My typical use-case is very unoriginal :-) For instance :

- I take 10 family pictures in a row because I'm a very bad photographer. Obviously, there are many similar ones and it makes no sense to keep them all.

- So I mark the first 6 to activate the comparison feature.

- in the mosaic, I can see easily which pictures are too blurry, so I delete them. If some pics are incredibly beautiful, I un-mark them, and select the next ones. If some are really similar I try to check which one is the best, put some to the bin, un-select the other ones.

- when space is freed in the mosaic, I select more (+ sign in the top bar) to add them to the mosaic

Obviously, if the mosaic was not constrained to 6 pics, I could select my ten pics right away. Although I might not select all 10 because (depending on my screen resolution) it might be difficult to see which ones are really blurry inside the mosaic. But I guess at least, if there was no limit, it would be up to the user to decide whether he selects 6, 8 or 10 pics. If there was a 6 limit it would be fine : no bug triggered. And if there was a queue system, it would be equivalent to what I do manually right now to work around the bug (select 6, unselect/delete some, select more).

One could imagine improvements of this feature to make it even better : possibility to temporarily see one (or several pics) bigger when you are not sure if 1 or 2 pics inside the mosaic is blurry or not (without having to deselect the others). Or possibility to re-order the pics inside the mosaic (if you find pairs for instance). Or assign colour-codes etc. Many possible ideas but that's another story :)

Thanks everyone, been loving gwenview for 13 years ;)
Comment 7 null 2017-11-04 12:15:30 UTC
*** Bug 313311 has been marked as a duplicate of this bug. ***
Comment 8 Holger 2017-11-04 15:46:05 UTC
My usage is often to only compare two images. So a limit of 6 is fine for me.

Especially for the split in half version, I'd love to see a possibility to toggle the split from vertical to horizontal, e.g. panorama pictures tend to be fairly wide and comparing two of them will result in a single row in the middle of the screen with a lot of wasted space above and below.

Maybe you could test both layouts and choose the one with maximum overall zoom level when fitting each picture to its respective box.

In addition, comparing a landscape picture to a portrait, the divider doesn't have to be exactly in the middle. The landscape will require as much width as possible, while the portrait can't take advantage of the width, once it touches the upper/lower edges.
Comment 9 Justin Zobel 2020-11-29 23:19:28 UTC
Thanks for the report. I've just tested this on gwenview 20.08.3 and I can't reproduce the issue. All images are shuffled as expected to show them in a logical way.

Can you please test and confirm if this issue is still occurring or if this bug report can be marked as resolved. I've set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks.
Comment 10 Bug Janitor Service 2020-12-14 04:33:55 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 11 Bug Janitor Service 2020-12-29 04:34:28 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 12 Mahendra Tallur 2020-12-29 08:30:28 UTC
Hi ! I've checked with the latest Gwenview version (20.12.0) and it seems the aforementioned issues still apply. None of them are really deal breaker.

1) as depicted in the initial reporter post : when more than 6 pictures are selected for comparisons, only the first 6 are displayed

2) if for instance you select 7 pics for comparison and unselect any of the first 6 ones displayed on the screen as expected in the mosaic, the 7 is immediatly displayed alone in fullscreen, but still with the relevant toolbar at the bottom. (if you had chosen 8 pics, you'd have 2 fullscreen pics etc.)

3) if you unselect this 7th picture (which has actually become the 6th), the mosaic is displayed again with, as expected, 5 pictures

So the initial bug is still here. It also raises the need for potential improvements : 

4) could the maximum number of compared picture be raised over 6 (people now have sometimes huge screens :) -- or really constrained to 6 without raising the bug ?

5) could the mosaic grid be improved / optimized based on the pics ratios ? (probably more complicated !)

Thank you to everyone... Been using Gwenview for 16 years, love it !
Comment 13 Justin Zobel 2021-01-01 09:08:43 UTC
(In reply to Mahendra Tallur from comment #12)
> Hi ! I've checked with the latest Gwenview version (20.12.0) and it seems
> the aforementioned issues still apply. None of them are really deal breaker.
> 
> 1) as depicted in the initial reporter post : when more than 6 pictures are
> selected for comparisons, only the first 6 are displayed
> 
> 2) if for instance you select 7 pics for comparison and unselect any of the
> first 6 ones displayed on the screen as expected in the mosaic, the 7 is
> immediatly displayed alone in fullscreen, but still with the relevant
> toolbar at the bottom. (if you had chosen 8 pics, you'd have 2 fullscreen
> pics etc.)
> 
> 3) if you unselect this 7th picture (which has actually become the 6th), the
> mosaic is displayed again with, as expected, 5 pictures
> 
> So the initial bug is still here. It also raises the need for potential
> improvements : 
> 
> 4) could the maximum number of compared picture be raised over 6 (people now
> have sometimes huge screens :) -- or really constrained to 6 without raising
> the bug ?
> 
> 5) could the mosaic grid be improved / optimized based on the pics ratios ?
> (probably more complicated !)
> 
> Thank you to everyone... Been using Gwenview for 16 years, love it !

Thanks for the update. Can you please raise the other improvement requests in separate reports so they can be individually tracked and voted on? You can use the wishlist sub-priority to indicate that they are feature requests.