Bug 349398

Summary:	kcoreaddons_desktop_to_json() does not update the target
Product:	[Frameworks and Libraries] frameworks-kcoreaddons	Reporter:	Jarosław Staniek <staniek>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	kdelibs-bugs
Priority:	NOR
Version:	5.1.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	attachment-12666-0.html

Description Jarosław Staniek 2015-06-19 22:04:22 UTC

Unless I missed something, after the related .desktop file changes kcoreaddons_desktop_to_json() does not update the target.

Instead, to force update (compiling-in a new json data) I need to:
1. re-run cmake in the builddie to update the json file
2. 'make clean' in the plugin's dir
3. make

Reproducible: Always




This is rather error-prone behaviour.

Comment 1 Adam Pigg 2015-06-20 07:22:27 UTC

Created attachment 93255 [details]
attachment-12666-0.html

Confirmed also when doing the kreport port, was quite frustrating until I
figured out why the changes werent being seen! :)

On Fri, Jun 19, 2015 at 11:04 PM, Jarosław Staniek <staniek@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=349398
>
>             Bug ID: 349398
>            Summary: kcoreaddons_desktop_to_json() does not update the
>                     target
>            Product: frameworks-kcoreaddons
>            Version: 5.1.0
>           Platform: Other
>                 OS: Linux
>             Status: UNCONFIRMED
>           Severity: normal
>           Priority: NOR
>          Component: general
>           Assignee: mpyne@kde.org
>           Reporter: staniek@kde.org
>                 CC: kdelibs-bugs@kde.org
>
> Unless I missed something, after the related .desktop file changes
> kcoreaddons_desktop_to_json() does not update the target.
>
> Instead, to force update (compiling-in a new json data) I need to:
> 1. re-run cmake in the builddie to update the json file
> 2. 'make clean' in the plugin's dir
> 3. make
>
> Reproducible: Always
>
>
>
>
> This is rather error-prone behaviour.
>
> --
> You are receiving this mail because:
> You are watching the reporter of the bug.
>

Comment 2 Jarosław Staniek 2015-07-14 20:26:33 UTC

Confirmed by Adam.

Comment 3 Michael Pyne 2017-08-06 21:53:19 UTC

Going through old bugs, but I'm not able to reproduce this.  The CMake code for this is in KF5CoreAddonsMacros.cmake, which seems to indicate that this might be a CMake bug fixed in CMake 3.0.0.

If it's possible to reproduce with a more recent CMake please reopen, but the "touch desktop file; re-run make" trick worked fine for me.