| Summary: | knetwalk 3.3.0 does not update network node icons | ||
|---|---|---|---|
| Product: | [Applications] knetwalk | Reporter: | Max <thesourcehim> |
| Component: | general | Assignee: | Ashwin Rajeev <ashwin_rajeev> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | fuzzythebear, giorgosk67, hatto, karaka22, kde-games-bugs, simonandric5, stefan, thesirdmz, xdarkmatter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/knetwalk/6c6d71ad0822bf6b48e1c84a790ac1106e0af88b | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot showing the bug
new version file qml/logic.js improved version file qml/logic.js |
||
|
Description
Max
2015-06-04 07:35:05 UTC
Note that this is new as of KDE 5 (at least for me it is). In KDE 4, those KNetWalk monitors would turn on properly when connected to the server. I confirm this bug is also present in knetwalk on Kubuntu 16.04. Sound of turning on/off is present, icon does not update. Version 3.3.0 Using: KDE Frameworks 5.18.0 Qt 5.5.1 (built against 5.5.1) The xcb windowing system Created attachment 102728 [details]
Screenshot showing the bug
I can confirm this bug. Neither connecting nor disconnecting a node causes the node icon to change. In former versions (KDE 4) this used to work.
KDE Frameworks 5.21.0
Qt 5.5.1 (kompiliert gegen 5.5.1)
Das xcb Fenstersystem
Repository: KDE 5 Applications
Name: knetwalk
Version: 16.11.90-2.6
Arch: x86_64
Vendor: obs://build.opensuse.org/KDE
Created attachment 103145 [details]
new version file qml/logic.js
Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/) solves this bug. There's just one line which has been added.
No new compiling needed, so this can be done even by beginners.
Should work in versions at least from 15.04 to 16.12, probably more.
This fix works, thank you. Not sure however, it may create a memory leak. May be destroy previous object too? It requires to store object links somewhere. Created attachment 103149 [details]
improved version file qml/logic.js
Substituting the file logic.js (in my case located in /usr/share/knetwalk/qml/) solves this bug. This is an improved version which avoids to create unnecessary new nodes (and memory leaks).
No new compiling needed, so this can be done even by beginners.
Should work in versions at least from 15.04 to 16.12, probably more.
It works great! Thank you Git commit 6c6d71ad0822bf6b48e1c84a790ac1106e0af88b by Albert Astals Cid, on behalf of Hatto von Hatzfeld. Committed on 03/01/2017 at 22:52. Pushed by aacid into branch 'Applications/16.12'. Fix network nodes not getting updated M +3 -0 src/qml/logic.js https://commits.kde.org/knetwalk/6c6d71ad0822bf6b48e1c84a790ac1106e0af88b *** Bug 389399 has been marked as a duplicate of this bug. *** *** Bug 399877 has been marked as a duplicate of this bug. *** bug reappeared in 3.3.0 Using:
KDE Frameworks 5.18.0
Qt 5.5.1 (built against 5.5.1)
The xcb windowing system
exactly the same issue. used to work fine .. now when you connect or disconnect a terminal it dont show the color change in the terminal. reinstalled .. same issue.
steps to reproduce : 1) start game
2) flip in out , color stays black
(In reply to Richard Hebert from comment #11) > bug reappeared in 3.3.0 Using: > KDE Frameworks 5.18.0 > Qt 5.5.1 (built against 5.5.1) > The xcb windowing system > > exactly the same issue. used to work fine .. now when you connect or > disconnect a terminal it dont show the color change in the terminal. > reinstalled .. same issue. > > steps to reproduce : 1) start game > 2) flip in out , color stays black Works fine here KDE Plasma Version: 5.18.5 KDE Frameworks Version: 5.68.0 Qt Version: 5.13.2 |