Bug 348444

Summary:	Currently active preset highlighting lost, by switching from tag "All" > to any other tag > back again to "All"
Product:	[Applications] krita	Reporter:	mvowada <freebox64>
Component:	Resource Management	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	brummerke90, guruguru.sp, halla, portnov, sven.langkamp
Priority:	NOR
Version:	2.9.4
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:	http://commits.kde.org/calligra/f5df93f0f2017e12f2b5670ad3df4f53969c5f28	Version Fixed In:
Attachments:	Video. Video

Description mvowada 2015-05-30 11:40:50 UTC

By selecting a tag and switching back to the predefined tag "All" you'll loose the highlighting of the currently active preset (it still works though).
When coming back the new highlighted preset is always "Airbrush_eraser".

Reproducible: Always

Steps to Reproduce:
1. with fresh Krita select a tag either from the brush docker or the toolbar list
2. switch back to tag "All" again

Actual Results:  
You loose the highlighting of the currently active preset (it still works though).

Expected Results:  
The current active preset remains highlighted.

(This report is half-related to Bug 348130, which in turn becomes a duplicate of this one, being included here by now).

Comment 1 mvowada 2015-05-30 11:41:35 UTC

*** Bug 348130 has been marked as a duplicate of this bug. ***

Comment 2 mvowada 2015-05-30 11:42:44 UTC

Created attachment 92922 [details]
Video.

Comment 3 mvowada 2015-05-30 11:45:10 UTC

Tested with Krita 2.9.4 (git d6827e4).

Comment 4 guruguru.sp 2015-06-20 15:12:22 UTC

This still happens in Krita 2.9.5.1.
It seems to me that on changing tags, the first item always gets highlighted. So after changing to some other tag then back to the original tag, the first item of the original tag gets highlighted and it might be different from the active preset.

Comment 5 Ilya V. Portnov 2015-06-21 09:13:27 UTC

Reproduces on today build from git calligra/2.9. 
After changing tag, the first item is highlighted always, but not activated. So you still work with your previous preset. To actually activate the preset highlighted, you need to click on another preset, and only then click on the first preset in the list.

Comment 6 Stefano Bonicatti 2015-06-21 21:37:29 UTC

Git commit f5df93f0f2017e12f2b5670ad3df4f53969c5f28 by Stefano Bonicatti.
Committed on 21/06/2015 at 21:34.
Pushed by stefanobonicatti into branch 'calligra/2.9'.

Fix selection bugs in the preset docker

Now is possible to select again a brush that is the only one in the
selected tag category.

When switching tag categories if the selected preset is present in the new
category, it will be selected, otherwise no preset will be, visually, selected,
but the active one won't be changed, so the user can still paint.

Added several checks to avoid unneeded executions and event emitting.
Especially now it shouldn't be possible to break the previous preset
selection/shortcut anymore.
Related: bug 348120
Differential Revision: https://phabricator.kde.org/D124

M  +25   -6    krita/ui/kis_paintop_box.cc
M  +22   -13   libs/widgets/KoResourceItemChooser.cpp
M  +1    -1    libs/widgets/KoResourceItemChooser.h
M  +5    -6    libs/widgets/KoResourceModel.cpp
M  +2    -2    libs/widgets/KoResourceModel.h

http://commits.kde.org/calligra/f5df93f0f2017e12f2b5670ad3df4f53969c5f28

Comment 7 mvowada 2015-06-30 22:19:54 UTC

(In reply to Stefano Bonicatti from comment #6)
> Fix selection bugs in the preset docker
> 
> Now is possible to select again a brush that is the only one in the
> selected tag category.
> 
> When switching tag categories if the selected preset is present in the new
> category, it will be selected, otherwise no preset will be, visually,
> selected,
> but the active one won't be changed, so the user can still paint.
> 
> Added several checks to avoid unneeded executions and event emitting.
> Especially now it shouldn't be possible to break the previous preset
> selection/shortcut anymore.
> Related: bug 348120
> Differential Revision: https://phabricator.kde.org/D124
> 
> M  +25   -6    krita/ui/kis_paintop_box.cc
> M  +22   -13   libs/widgets/KoResourceItemChooser.cpp
> M  +1    -1    libs/widgets/KoResourceItemChooser.h
> M  +5    -6    libs/widgets/KoResourceModel.cpp
> M  +2    -2    libs/widgets/KoResourceModel.h
> 
> http://commits.kde.org/calligra/f5df93f0f2017e12f2b5670ad3df4f53969c5f28

Hello Stefano, thank you for this commit :-)
I've double checked with a more recent version of Krita: 2.9.5 (git 9fe0557). Unfortunately it seems that both these issues are still reproducible: Bug 348444 and Bug 348120.
Please see the video below. Reopening.

Comment 8 mvowada 2015-06-30 22:21:15 UTC

Created attachment 93435 [details]
Video

Comment 9 wolthera 2016-07-08 14:16:37 UTC

*** Bug 364704 has been marked as a duplicate of this bug. ***

Comment 10 mvowada 2017-01-04 11:39:04 UTC

I can't reproduce this issue anymore with Krita 3.1.1. Closing this report as 'RESOLVED FIXED'.