Bug 346120

Summary:	'Remote Control' page UI is too narrow
Product:	[Applications] kdeconnect	Reporter:	Nerijus Baliūnas <nerijus>
Component:	android-application	Assignee:	Albert Vaca Cintora <albertvaka>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Android
OS:	Linux
Latest Commit:	http://commits.kde.org/kdeconnect-android/c647cbd93c498f9c0e415c1b3000a473fdfb510c	Version Fixed In:
Sentry Crash Report:
Attachments:	too narrow in portrait mode Here the width is OK in portrait mode too wide left and right margins marked with red lines patched

Description Nerijus Baliūnas 2015-04-12 21:36:32 UTC

The continuation of bug 339684.
The screen could still be wider as seen in attached screenshots.

It would be nice to scroll the song name if it does not fit.

Reproducible: Always

Comment 1 Nerijus Baliūnas 2015-04-12 21:41:09 UTC

Created attachment 91998 [details]
too narrow in portrait mode

Comment 2 Nerijus Baliūnas 2015-04-12 21:41:52 UTC

Created attachment 91999 [details]
Here the width is OK in portrait mode

Comment 3 Nerijus Baliūnas 2016-01-12 12:53:33 UTC

Created attachment 96599 [details]
too wide left and right margins marked with red lines

I marked too wide left and right margins with red lines. If left and right margins were narrower, then more text would fit to screen. As you can see, the song name does not fit completely.

Comment 4 Nerijus Baliūnas 2016-01-12 12:59:37 UTC

Created attachment 96600 [details]
patched

This is how it looks when the following patch is applied:

diff --git a/res/layout/mpris_control.xml b/res/layout/mpris_control.xml
index daba05a..25961f8 100644
--- a/res/layout/mpris_control.xml
+++ b/res/layout/mpris_control.xml
@@ -7,9 +7,9 @@
     android:layout_height="match_parent"
     android:id="@+id/mpris_control_view"
     android:gravity="center"
-    android:paddingLeft="60dip"
+    android:paddingLeft="5dip"
     android:paddingTop="5dip"
-    android:paddingRight="60dip"
+    android:paddingRight="5dip"
     android:paddingBottom="5dip">
 
     <TextView

Comment 5 Nerijus Baliūnas 2016-01-18 09:19:55 UTC

The latest git added scrolling the song name if it does not fit. But the margins could still be smaller. The following patch works OK on my phone and looks good:

diff --git a/res/layout/mpris_control.xml b/res/layout/mpris_control.xml
index 80143b1..782eb23 100644
--- a/res/layout/mpris_control.xml
+++ b/res/layout/mpris_control.xml
@@ -7,9 +7,9 @@
     android:layout_height="match_parent"
     android:id="@+id/mpris_control_view"
     android:gravity="center"
-    android:paddingLeft="60dip"
+    android:paddingLeft="30dip"
     android:paddingTop="5dip"
-    android:paddingRight="60dip"
+    android:paddingRight="30dip"
     android:paddingBottom="5dip">
 
     <TextView

Comment 6 Albert Vaca Cintora 2016-01-18 10:30:32 UTC

Git commit 93522c9648333ad1a28ea3d80d6cf532990294d6 by Albert Vaca.
Committed on 18/01/2016 at 10:30.
Pushed by albertvaka into branch '0.9'.

Made MPRIS interface wider

M  +2    -2    res/layout/mpris_control.xml

http://commits.kde.org/kdeconnect-android/93522c9648333ad1a28ea3d80d6cf532990294d6

Comment 7 Albert Vaca Cintora 2016-01-18 10:31:03 UTC

Done!

Comment 8 Albert Vaca Cintora 2016-01-18 10:44:00 UTC

Git commit c647cbd93c498f9c0e415c1b3000a473fdfb510c by Albert Vaca.
Committed on 18/01/2016 at 10:42.
Pushed by albertvaka into branch 'master'.

Made MPRIS interface wider

M  +2    -2    res/layout/mpris_control.xml

http://commits.kde.org/kdeconnect-android/c647cbd93c498f9c0e415c1b3000a473fdfb510c