Summary: | user-places.xbel regularly gets overridden (so custom places disappear) | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | Jiehong <email> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | RESOLVED DUPLICATE | ||
Severity: | major | CC: | AndyKluger, bhush94, emmanuelpescosta099, marco_silva85, notmart, simonandric5, xplwowi |
Priority: | NOR | ||
Version: | 5.2.0 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Jiehong
2015-02-03 13:06:48 UTC
are the applications such as Dolphin or konqueror KDE4 or KF5 based? any idea who is actually writing user-places.xbel ? Dolphin Version 14.11.97 (actually 14.12.1 according to the package) Using KDE Development Platform 4.14.4 Konqueror Version 4.14.4 (actually 14.12.1 according to the package) Using KDE Development Platform 4.14.4 I wish I knew what application were modifying the file, but I only have the information of when that file were modified (with stat for example). Logs don't contain `user-places`, and the activity around the time of modification is not very helpful. `audit` is not activated in the Archlinux kernel, so monitoring the file's access and modifications require a custom kernel that I haven't. Duplicate of bug 342685? looks it, thanks. *** This bug has been marked as a duplicate of bug 342685 *** Git commit e7e0f2d8f06e4086a1872757d779e19a06537b2a by Marco Martin. Committed on 09/02/2015 at 17:18. Pushed by mart into branch 'master'. sync bookmarkmanager only if change was by process This is an attempt to fix a bug that seems quite difficult to reproduce, It seems there is a weird race condition linked to the sync of the two files .local/share/user-places.xbel .local/share/kfileplaces/bookmarks.xml causing the bug https://bugs.kde.org/show_bug.cgi?id=343735 all processes that are listening for changes in the bookmark manager will try to sync their bookmarks with the shared ones (user-places.xbel) and depending what process arrives first, some bookmarks may be lost The same commit will happen on kdelibs4 as well REVIEW:122459 M +9 -0 src/filewidgets/kfileplacesmodel.cpp M +1 -6 src/filewidgets/kfileplacessharedbookmarks.cpp M +2 -1 src/filewidgets/kfileplacessharedbookmarks_p.h http://commits.kde.org/kio/e7e0f2d8f06e4086a1872757d779e19a06537b2a Git commit 2b5c6e42fc8114c6854ce490b9cdd4356be683d9 by Marco Martin. Committed on 09/02/2015 at 17:22. Pushed by mart into branch 'KDE/4.14'. sync bookmarkmanager only if change was by process This is an attempt to fix a bug that seems quite difficult to reproduce, It seems there is a weird race condition linked to the sync of the two files .local/share/user-places.xbel .local/share/kfileplaces/bookmarks.xml causing the bug https://bugs.kde.org/show_bug.cgi?id=343735 all processes that are listening for changes in the bookmark manager will try to sync their bookmarks with the shared ones (user-places.xbel) and depending what process arrives first, some bookmarks may be lost The same commit will happen on kdelibs4 as well REVIEW:122459 M +9 -0 kfile/kfileplacesmodel.cpp M +1 -6 kfile/kfileplacessharedbookmarks.cpp M +2 -2 kfile/kfileplacessharedbookmarks_p.h http://commits.kde.org/kdelibs/2b5c6e42fc8114c6854ce490b9cdd4356be683d9 Emmanuel: should the same commit happen on dolphin as well? or even better: could Dolphin be made use kfileplacesmodel (expanded as necessary) as well? (In reply to Marco Martin from comment #7) > Emmanuel: should the same commit happen on dolphin as well? Given that the Dolphin places model uses a lot of kfileplacesmodel code, I think we have to apply the same changes in Dolphin as well. But I'll check it and come up with a patch. > could Dolphin be made use kfileplacesmodel (expanded as necessary) as well? kfileplacesmodel and Dolphin have different model interfaces (QModelIndex vs itemviews-ng), so it isn't a real drop-in replacement. But merging them in the long term is definitely something to keep in mind ;) still happens as of today in archlinux current. Using KDE 4. could it be related to usage of KDE Connect? (since it edits user-places to add a item for remote browsing the phone) (In reply to Marco Silva from comment #9) > still happens as of today in archlinux current. Using KDE 4. > could it be related to usage of KDE Connect? (since it edits user-places to > add a item for remote browsing the phone) Please have a look at https://bugs.kde.org/show_bug.cgi?id=345174 |