| Summary: | Crop Tool loses constant ratio after the handles touching canvas edges | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Tools/Transform | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | flat, freebox64, ghevan, halla, thinkinmonkey, victor.wahlstrom, wubz |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/8d032ed4bd01eb2a28eaff42c78ec2d56e36b850 | Version Fixed In: | |
| Attachments: |
Crop Tool loses constant ratio after touching either edge of the canvas
I can confirm. The crop box doesn't respect the ratio when is dragged over the canvas edges. In my opinion, this behavior frustrates the point of having set a fixed ratio (video in attachment) |
||
|
Description
Tyson Tan
2015-01-30 19:49:44 UTC
Created attachment 90820 [details]
Crop Tool loses constant ratio after touching either edge of the canvas
In this screenshot I was dragging the Crop Tool from bottom-right to top-left. I continue to drag outward after the handles touching the left side of the canvas. You can see Keep Ratio was checked, value set to 1.00, but the Crop Area is definitely not square.
Created attachment 91316 [details]
I can confirm. The crop box doesn't respect the ratio when is dragged over the canvas edges. In my opinion, this behavior frustrates the point of having set a fixed ratio (video in attachment)
What would the preferred behaviour be? Don't shrink the box and simply stop once it reaches the crop border, or shrink the box but respect aspect ratio? (In reply to Victor Wåhlström from comment #3) > What would the preferred behaviour be? Don't shrink the box and simply stop > once it reaches the crop border, or shrink the box but respect aspect ratio? Hello, personally I'd like it to be "Don't shrink the box and simply stop once it reaches the crop border". Actually -- When "Grow" is unchecked: Stop enlarging crop area once the moving side touches the edge of the canvas. When "Grow" is checked: Allow enlarging crop area in any case but always respect ratio. *** Bug 333369 has been marked as a duplicate of this bug. *** Anyone who builds krita themselves, please test https://invent.kde.org/kde/krita/merge_requests/162 Git commit 9b45d78661e01f54f5bd78ae2233407ee79d0ea3 by Ivan Yossi. Committed on 04/10/2019 at 16:25. Pushed by ivany into branch 'master'. Fix Crop tool loosing aspect ratio on move Previously there was no check for boundaries after the new rect position is calculated. Before applying any offset on move drag we check we no longer go ouside of the image bounds. For aspect ratio we keep aspect ratio growing into the image instead of outwards getting some weird behaviour M +22 -0 plugins/tools/tool_crop/kis_constrained_rect.cpp https://invent.kde.org/kde/krita/commit/9b45d78661e01f54f5bd78ae2233407ee79d0ea3 Thank you Vanyossi! :D Git commit 8d032ed4bd01eb2a28eaff42c78ec2d56e36b850 by Boudewijn Rempt, on behalf of Ivan Yossi. Committed on 09/10/2019 at 08:40. Pushed by rempt into branch 'krita/4.2'. Fix Crop tool loosing aspect ratio on move Previously there was no check for boundaries after the new rect position is calculated. Before applying any offset on move drag we check we no longer go ouside of the image bounds. For aspect ratio we keep aspect ratio growing into the image instead of outwards getting some weird behaviour (cherry picked from commit 9b45d78661e01f54f5bd78ae2233407ee79d0ea3) M +22 -0 plugins/tools/tool_crop/kis_constrained_rect.cpp https://invent.kde.org/kde/krita/commit/8d032ed4bd01eb2a28eaff42c78ec2d56e36b850 *** Bug 413334 has been marked as a duplicate of this bug. *** |