| Summary: | Calendar applet should display week number when in panel | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Chris Warrick <kwpolska> |
| Component: | Calendar widget | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | chaboisseau, cyberbeat, kde, kde, kwpolska, t.kleindienst |
| Priority: | NOR | ||
| Version: | 5.1.95 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-workspace/857c0680f5c801f98f182a209f3aef02255dda83 | Version Fixed In: | 5.7.0 |
| Sentry Crash Report: | |||
| Attachments: |
top - kde 4; bottom - kde 5
top = KDE 4 and bottom = KDE 5 |
||
|
Description
Chris Warrick
2015-01-28 16:09:41 UTC
Thanks for the report. Which calendar icon do you have in mind? Created attachment 90753 [details]
top - kde 4; bottom - kde 5
The attachment shows the icon; it’s displayed on the panel (when a calendar is there). Ah right. We never actually considered using the calendar applet like that, more like putting it on the desktop as the same calendar popup is with the clock applet. But I guess it could be made more useful... *** Bug 343713 has been marked as a duplicate of this bug. *** I am affected by this, too. It would be nice if the calendar applet also shows the number of the week. Created attachment 94494 [details]
top = KDE 4 and bottom = KDE 5
I would go further than what the screenshot describes (namely that the calendar icon should display the week number) and support that the *whole calendar* browsing should display the week number for each row (this is very useful when setting up a meeting).
See latest screenshot of how the 2 versions of calendar are presented
(top for KDE4 and bottom for KDE5)
> the *whole calendar* browsing should display the week number for each row
This is already done in Plasma 5.4.
I had a look at this just now but given how horrible JS Date() is I have no idea how to make this work properly without 1.) adding a C++ plugin or 2.) making a horrible JS hack. Other than that my patch works, you can even choose between having the day of month or week of year shown. The Calendar applet already should have the C++ backend no? Maybe we could make the week number available on the top-level item of the Calendar and then just reuse in the compact representation? Git commit 857c0680f5c801f98f182a209f3aef02255dda83 by Kai Uwe Broulik. Committed on 15/06/2016 at 12:58. Pushed by broulik into branch 'master'. [Calendar Applet] Show day or week number in icon Rather than showing the generic calendar icon the day number is shown there instead. There is also an option to have it show the week number instead. FIXED-IN: 5.7.0 Differential Revision: https://phabricator.kde.org/D1867 M +1 -1 applets/CMakeLists.txt A +14 -0 applets/calendar/CMakeLists.txt C +21 -17 applets/calendar/calendarapplet.cpp [from: applets/calendar/contents/ui/configGeneral.qml - 063% similarity] C +18 -16 applets/calendar/calendarapplet.h [from: applets/calendar/contents/config/config.qml - 066% similarity] R +0 -0 applets/calendar/package/contents/config/config.qml [from: applets/calendar/contents/config/config.qml - 100% similarity] R +3 -0 applets/calendar/package/contents/config/main.xml [from: applets/calendar/contents/config/main.xml - 087% similarity] R +- -- applets/calendar/package/contents/images/mini-calendar.svgz [from: applets/calendar/contents/images/mini-calendar.svgz - 100% similarity] R +0 -0 applets/calendar/package/contents/ui/configAgenda.qml [from: applets/calendar/contents/ui/configAgenda.qml - 100% similarity] R +31 -0 applets/calendar/package/contents/ui/configGeneral.qml [from: applets/calendar/contents/ui/configGeneral.qml - 052% similarity] R +42 -8 applets/calendar/package/contents/ui/main.qml [from: applets/calendar/contents/ui/main.qml - 063% similarity] R +0 -0 applets/calendar/package/metadata.desktop [from: applets/calendar/metadata.desktop - 100% similarity] http://commits.kde.org/plasma-workspace/857c0680f5c801f98f182a209f3aef02255dda83 |