Summary: | Improve the info panel for photos | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kfilemetadata | Reporter: | Martin Klapetek <mklapetek> |
Component: | general | Assignee: | Pinak Ahuja <pinak.ahuja> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | aspotashev, bugseforuns, cfeck, fincer89, frank78ac, nate, stefan.bruens |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/baloo-widgets/b9fcf84f7fa3d9584b9d77dbc4641a21d0d7ac5c | Version Fixed In: |
Description
Martin Klapetek
2015-01-25 11:57:37 UTC
Dolphin displays the data the way it obtains them from specialized metadata libraries. If the labels and/or values are not suitable for the display, I strongly believe that should be fixed in those libraries, instead of worked around in any client that uses those libraries. Right, in Dolphin5 the KFileMetadata is used for that sidebar and those names should be changed there (I can see they are being direct transliteration of the exiv keys). That's why I added Vishesh in CC. Though on a second thought maybe I should have filed a special report just for the renaming and the values format. In fact, how much of the info sidebar is Dolphin and how much is KFileMetadata? I'm thinking maybe this whole change would go just into KFileMetadata? (In reply to Martin Klapetek from comment #2) > In fact, how much of the info sidebar is Dolphin and how much is > KFileMetadata? The widget in the Information Panel ist the FileMetaDataWidget from Baloo. I'm not sure though how much of what you suggest needs to be done there, and how much in KFileMetaData. Martin, do you think you could provide a patch? * The translated names come from KFileMetaData. Have a look at propertyinfo.cpp * The actual widget comes from baloo-widgets. This is because the data is indexed in Baloo (and cached for faster lookups) - This could be changed if someone wants to do it. It's just the way things currently are. Alright, I can sure give it a try. Git commit e2bd6629783e6a884a23924c99c2fe32b0c8559f by Alexander Stippich. Committed on 12/02/2019 at 21:33. Pushed by astippich into branch 'master'. Format EXIF photo flash data Summary: Translate the number of the EXIF photo data to a human readable string. Reviewers: ngraham Reviewed By: ngraham Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D18972 M +4 -0 autotests/propertyinfotest.cpp M +40 -0 src/formatstrings.cpp M +2 -0 src/formatstrings_p.h M +1 -0 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/e2bd6629783e6a884a23924c99c2fe32b0c8559f Git commit 3983d80727b4bb3ab5692386991389f7ffcd7ffd by Alexander Stippich. Committed on 30/05/2019 at 11:46. Pushed by astippich into branch 'master'. Cleanup default filters for baloo-widgets Summary: The property names do not match any names defined in KFileMetaData. While the intention of the previous filters clearly was to hide most of the EXIF information, users seem to use the provided information (see bug report), so show most of it. Hide photo metering mode, photo sharpness and white balance, as they seem to be quite useless. Reviewers: ngraham, bruns Reviewed By: bruns Subscribers: #baloo Tags: #baloo Differential Revision: https://phabricator.kde.org/D21413 M +7 -22 src/metadatafilter.cpp https://commits.kde.org/baloo-widgets/3983d80727b4bb3ab5692386991389f7ffcd7ffd Git commit de67dcb8263c6e3d52782372b555c75f4500b167 by Alexander Stippich. Committed on 30/05/2019 at 11:47. Pushed by astippich into branch 'master'. Show 3 significant figures when displaying doubles Summary: Show 3 significant digits for double values when displaying them with e.g. baloo-widgets Also fixes localization Reviewers: ngraham, bruns Reviewed By: bruns Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21499 M +27 -21 autotests/propertyinfotest.cpp M +5 -0 src/formatstrings.cpp M +2 -0 src/formatstrings_p.h M +9 -0 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/de67dcb8263c6e3d52782372b555c75f4500b167 Git commit bfef0997eb771fdff5a87cbef8cad2e1fe7bd2f5 by Alexander Stippich. Committed on 05/06/2019 at 19:33. Pushed by astippich into branch 'master'. Hide more exif data Summary: Hide some additional information retrieved from exif, which seems not to be useful Reviewers: ngraham, bruns Reviewed By: ngraham, bruns Subscribers: #baloo Tags: #baloo Differential Revision: https://phabricator.kde.org/D21520 M +3 -0 src/metadatafilter.cpp https://commits.kde.org/baloo-widgets/bfef0997eb771fdff5a87cbef8cad2e1fe7bd2f5 Git commit 553f967696103099c197a59a206e3ebcce443b5d by Alexander Stippich. Committed on 05/06/2019 at 19:34. Pushed by astippich into branch 'master'. Format the aperture values as F numbers. Summary: CCBUG: 343273 Reviewers: bruns, ngraham Reviewed By: ngraham Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21532 M +2 -0 autotests/propertyinfotest.cpp M +5 -0 src/formatstrings.cpp M +2 -0 src/formatstrings_p.h M +3 -2 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/553f967696103099c197a59a206e3ebcce443b5d Git commit 2dc250bc9239d9f30f55110f4b3b8329c202a5c3 by Alexander Stippich. Committed on 10/06/2019 at 20:44. Pushed by astippich into branch 'master'. Format photo exposure time as rational when applicable Summary: If value is below 0.3, format the output as rational which is commonly used in photography. Value is computed from the double input value. Reviewers: bruns, ngraham Reviewed By: bruns Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21533 M +3 -2 autotests/propertyinfotest.cpp M +13 -0 src/formatstrings.cpp M +2 -0 src/formatstrings_p.h M +1 -1 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/2dc250bc9239d9f30f55110f4b3b8329c202a5c3 Git commit 131947acb0b2b065d5c23341785c97e52cbca292 by Alexander Stippich. Committed on 14/06/2019 at 19:23. Pushed by astippich into branch 'master'. Rename ImageMake and ImageModel properties Summary: Provide a more generic and meaningful property and display name for the previous ImageMake and ImageModel properties. Reviewers: ngraham, bruns Reviewed By: ngraham Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21519 M +2 -2 src/extractors/exiv2extractor.cpp M +22 -1 src/properties.h M +8 -8 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/131947acb0b2b065d5c23341785c97e52cbca292 Git commit 135fc25b6feb6958f55645ad33ba1551bd16bd98 by Alexander Stippich. Committed on 14/06/2019 at 19:24. Pushed by astippich into branch 'master'. Remove photo prefix from every exif property name Summary: Remove the 'photo' prefix from every exif property, as this is pretty redundant Reviewers: ngraham, bruns Reviewed By: ngraham Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21772 M +18 -18 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/135fc25b6feb6958f55645ad33ba1551bd16bd98 Git commit 0a042beb5568a073612c2752b4c4b64b675e2a81 by Alexander Stippich. Committed on 21/06/2019 at 17:28. Pushed by astippich into branch 'master'. Format photo exposure bias value Summary: Format the photo exposure bias value in EV units and in steps of thirds when applicable Reviewers: bruns, ngraham Reviewed By: bruns Subscribers: kde-frameworks-devel, #baloo Tags: #frameworks, #baloo Differential Revision: https://phabricator.kde.org/D21830 M +8 -0 autotests/propertyinfotest.cpp M +33 -0 src/formatstrings.cpp M +2 -0 src/formatstrings_p.h M +1 -1 src/propertyinfo.cpp https://commits.kde.org/kfilemetadata/0a042beb5568a073612c2752b4c4b64b675e2a81 Git commit b9fcf84f7fa3d9584b9d77dbc4641a21d0d7ac5c by Alexander Stippich. Committed on 23/06/2019 at 18:05. Pushed by astippich into branch 'master'. Rework sorting of properties Summary: Rework sorting of properties in the file information panel and tooltips. Rename "audio" and "music" sorting key to "media" as they are also used for videos and images. Final piece for Reviewers: ngraham, bruns Reviewed By: ngraham Subscribers: #baloo Tags: #baloo Differential Revision: https://phabricator.kde.org/D22024 M +29 -15 src/filemetadataprovider.cpp https://commits.kde.org/baloo-widgets/b9fcf84f7fa3d9584b9d77dbc4641a21d0d7ac5c |