| Summary: | Softproofing in editor does not work anymore [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Guenther M. Erhard <guenther-digikam> |
| Component: | ColorManagement-Views | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, metzpinguin |
| Priority: | NOR | ||
| Version: | 4.7.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/digikam/198ce7028266a7da94708f544da729949d826360 | Version Fixed In: | 4.7.0 |
| Sentry Crash Report: | |||
| Attachments: |
softproofing.patch
softproofing2.patch |
||
|
Description
Guenther M. Erhard
2015-01-23 18:35:42 UTC
Which Lcms version you use with digiKam ? Look in Help/Components Info dialog for details. Can you share one image to process and color profile to use to try to reproduce the problem ? Gilles Caulier I have looked into the code of digikam 3.5.0. The code for softproofing has in digikam 4.7.0 at the moment no function. Maik MAik, No function ? Which code exist in 3.x which do not exist in 4.x ? Gilles Gilles,
I made the evening yesterday before a first hack.
Masks color still does not work, is always black.
editorcore.cpp:329
void EditorCore::updateColorManagement()
{
IccManager manager(d->image);
if (d->doSoftProofing)
{
d->monitorICCtrans = manager.displaySoftProofingTransform(d->cmSettings.defaultProofProfile, d->displayingWidget);
}
else
{
d->monitorICCtrans = manager.displayTransform(d->displayingWidget);
}
}
d->monitorICCtrans is set but never used.
d->displayingWidget is never set -> value 0.
The code to set color management is now in imagepreviewitem.cpp but no softproofing code.
Maik
Ah, yes, i understand now. It's another part dropped due to canvas model/view port between 3.x to 4.x. Code can be ported as well into imagepreviewitem.cpp without to many difficulties i think. Gilles Created attachment 90629 [details]
softproofing.patch
The weather today was bad here, snow slush. ;-) I put a patch ready for testing.
Softproofing works in the editor and in the tool preview.
Softproofing mask color is now correct viewed.
Created attachment 90630 [details]
softproofing2.patch
Const statement forget for a new function.
Git commit 198ce7028266a7da94708f544da729949d826360 by Gilles Caulier. Committed on 25/01/2015 at 11:11. Pushed by cgilles into branch 'master'. Apply patch from Maik Qualmann to restore Softproofing freature in Image Editor due to canvas model/view port initiate with 4.0.0 release while Google Summer of Code FIXED-IN: 4.7.0 M +2 -1 NEWS M +3 -3 libs/dklcms/digikam-lcms.cpp M +6 -31 utilities/imageeditor/core/editorcore.cpp M +1 -1 utilities/imageeditor/core/editorcore.h M +0 -2 utilities/imageeditor/core/editorcore_p.h M +1 -0 utilities/imageeditor/editor/editorwindow.cpp M +15 -4 utilities/imageeditor/plugin/imageiface.cpp M +0 -1 utilities/imageeditor/widgets/canvas.cpp M +14 -3 utilities/imageeditor/widgets/imagepreviewitem.cpp M +14 -3 utilities/imageeditor/widgets/imageregionitem.cpp http://commits.kde.org/digikam/198ce7028266a7da94708f544da729949d826360 Git commit 2c4f8691b5c1ab57c404cf718b6b64500ae94e3c by Gilles Caulier. Committed on 25/01/2015 at 11:34. Pushed by cgilles into branch 'frameworks'. backport commit #198ce7028266a7da94708f544da729949d826360 from git/master to frameworks branch M +3 -3 libs/dklcms/digikam-lcms.cpp M +7 -31 utilities/imageeditor/core/editorcore.cpp M +1 -1 utilities/imageeditor/core/editorcore.h M +0 -2 utilities/imageeditor/core/editorcore_p.h M +1 -0 utilities/imageeditor/editor/editorwindow.cpp M +15 -4 utilities/imageeditor/plugin/imageiface.cpp M +0 -1 utilities/imageeditor/widgets/canvas.cpp M +14 -3 utilities/imageeditor/widgets/imagepreviewitem.cpp M +14 -3 utilities/imageeditor/widgets/imageregionitem.cpp http://commits.kde.org/digikam/2c4f8691b5c1ab57c404cf718b6b64500ae94e3c Guys, You are great! Just recompiled digikam and and I can confirm that soft proofing is working again. Thanks a lot! Best regards, Guentehr |