| Summary: | Close button doesn't obey Fitts law | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Antonio Rojas <arojas> |
| Component: | window decoration | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | hugo.pereira.da.costa, notmart |
| Priority: | NOR | ||
| Version: | 5.1.95 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/breeze/ab80e3880f9a6928038147b339faafcf91279302 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Screenshot | ||
|
Description
Antonio Rojas
2015-01-15 08:10:23 UTC
kdecoration2 or aurora? kdecoration (using 5.2 beta) I cannot reproduce (with breeze) What exactly is your button layout ? (screenshot) and in fact there is another bug report complaining about missing margins, (because of top being removed), due to exactly the requirement of Fitts law. See: http://wstaw.org/m/2015/01/19/plasma-desktopt10138.png Created attachment 90506 [details]
Screenshot
I can only reproduce in my laptop, which has a high DPI and is using a 18pt font for the label text. In my other machine I'm using a 14pt size font and it works correctly
ok. Makes sense. This is because the text area is larger than the button area, in your laptop case and since the buttons are vertically centered, you get extra empty pixels around them (to match the font height) I guess I should extend their hit area instead Thanks for reporting, I'll work on it ! Git commit 4dd75758dcb1b970c5e1c6638df0fa4f1aab542e by Hugo Pereira Da Costa. Committed on 15/01/2015 at 10:07. Pushed by hpereiradacosta into branch 'master'. Moved buttons geometry handling to Breeze::decoration Do not change size of titlebar when maximizing. Expend buttons hit area to satisfy Fitts law in maximize mode Related: bug 342824 M +3 -12 kdecoration/breezebutton.cpp M +9 -0 kdecoration/breezebutton.h M +22 -15 kdecoration/breezedecoration.cpp M +8 -9 kdecoration/breezedecoration.h http://commits.kde.org/breeze/4dd75758dcb1b970c5e1c6638df0fa4f1aab542e Git commit ab80e3880f9a6928038147b339faafcf91279302 by Hugo Pereira Da Costa. Committed on 15/01/2015 at 10:07. Pushed by hpereiradacosta into branch 'Plasma/5.2'. Moved buttons geometry handling to Breeze::decoration Do not change size of titlebar when maximizing. Expend buttons hit area to satisfy Fitts law in maximize mode Related: bug 342824 M +3 -12 kdecoration/breezebutton.cpp M +9 -0 kdecoration/breezebutton.h M +22 -15 kdecoration/breezedecoration.cpp M +8 -9 kdecoration/breezedecoration.h http://commits.kde.org/breeze/ab80e3880f9a6928038147b339faafcf91279302 |
