| Summary: | Almost no padding for window icon in maximized window decoration | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Antonio Rojas <arojas> |
| Component: | window decoration | Assignee: | Hugo Pereira Da Costa <hugo.pereira.da.costa> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, hugo.pereira.da.costa, kde |
| Priority: | NOR | ||
| Version: | 5.1.95 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/breeze/ab80e3880f9a6928038147b339faafcf91279302 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Maximized window
unmaximized window, for comparison |
||
|
Description
Antonio Rojas
2015-01-14 08:26:05 UTC
Created attachment 90399 [details]
Maximized window
Created attachment 90400 [details]
unmaximized window, for comparison
Seems oxygen used to have an explicit shift in there:
from old oxygenbutton.cpp
if( _client.isMaximized() ) painter.translate( 0, 1 );
which is a bit weird, it only moves the painting not the actual hit area
*** Bug 342954 has been marked as a duplicate of this bug. *** Git commit 4dd75758dcb1b970c5e1c6638df0fa4f1aab542e by Hugo Pereira Da Costa. Committed on 15/01/2015 at 10:07. Pushed by hpereiradacosta into branch 'master'. Moved buttons geometry handling to Breeze::decoration Do not change size of titlebar when maximizing. Expend buttons hit area to satisfy Fitts law in maximize mode Related: bug 342864 M +3 -12 kdecoration/breezebutton.cpp M +9 -0 kdecoration/breezebutton.h M +22 -15 kdecoration/breezedecoration.cpp M +8 -9 kdecoration/breezedecoration.h http://commits.kde.org/breeze/4dd75758dcb1b970c5e1c6638df0fa4f1aab542e Note: padding on the top is now there. There is no padding on the left still because adding such a thing +and+ honouring Fitts law, would require to break spacing, (or to go into some quite complex code in order to add the needed spacing to the first left button and last right button, and on the right side) Edit: in the end I went for the extra mile and also implemented the horizontal padding, so that buttons should not move any more when maximizing, but hit area should be extended to satisfy Fitts law. Testing welcome (using master) I will backport to 5.2 after a couple of days testing, myself, and as soon as it is unfrozen. 5.2 isn't frozen for bug fixes ... yes but still I need couple of days testing because this stuff is breakage prone. (In reply to David Edmundson from comment #3) > Seems oxygen used to have an explicit shift in there: > > from old oxygenbutton.cpp > if( _client.isMaximized() ) painter.translate( 0, 1 ); > > which is a bit weird, it only moves the painting not the actual hit area believe me it all makes sense (tm) :) top padding is removed (Fitts law) bottom padding is kept painting is shifted to preserve vertical alignment. Only issue: it requires larger buttons (to accomodate the shift) For breeze I now chose a different solution: all padding is kept, hit area ( = buttons geometry) is increased (Fitts law), painting is shifted (to maintain alignment) Git commit ab80e3880f9a6928038147b339faafcf91279302 by Hugo Pereira Da Costa. Committed on 15/01/2015 at 10:07. Pushed by hpereiradacosta into branch 'Plasma/5.2'. Moved buttons geometry handling to Breeze::decoration Do not change size of titlebar when maximizing. Expend buttons hit area to satisfy Fitts law in maximize mode Related: bug 342864 M +3 -12 kdecoration/breezebutton.cpp M +9 -0 kdecoration/breezebutton.h M +22 -15 kdecoration/breezedecoration.cpp M +8 -9 kdecoration/breezedecoration.h http://commits.kde.org/breeze/ab80e3880f9a6928038147b339faafcf91279302 |