Summary: | kio thumbnail slave unable to create previews for .cbr files due to inabillity to identify unrar due to unrar having removed the --version flag since unrar 5.2.1 | ||
---|---|---|---|
Product: | [Unmaintained] kio | Reporter: | Jörg Schuck <joerg_schuck> |
Component: | thumbnail | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cfeck, disgruntled.mob, joerg_schuck, kde, massimiliano.torromeo, thetimemeddler |
Priority: | NOR | ||
Version: | 4.14.1 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio-extras/c734c5d5a1b47f749ef9230454f963b3b7daf573 | Version Fixed In: | |
Sentry Crash Report: | |||
Bug Depends on: | |||
Bug Blocks: | 367626 | ||
Attachments: | Proposed patch to fix the bug. |
Description
Jörg Schuck
2014-11-26 20:37:47 UTC
Created attachment 89736 [details]
Proposed patch to fix the bug.
Thanks Jörg for the patch. There are some coding style issues which are best discussed at reviewboard.kde.org. If you do not want to create a review request there, I will go through it in the coming days. This is still an issue in Dolphin 15.08 *** Bug 355368 has been marked as a duplicate of this bug. *** This bug still exists in Dolphin 15.12.2 I just submitted a patch for this https://git.reviewboard.kde.org/r/129255/ Git commit c734c5d5a1b47f749ef9230454f963b3b7daf573 by Albert Astals Cid. Committed on 20/01/2017 at 23:13. Pushed by aacid into branch 'Applications/16.12'. Fixed unrar version check The parameter "--version" stopped working since unrar 5.2 which was released almost 2 years ago. With this change this now becomes the minimum version required but every distribution that is going to relase a version with this commit has probably been using unrar > 5.2 for quite a while so I don't think there is any need to provide a fallback. Related: bug 367626 REVIEW: 129255 M +1 -1 thumbnail/comiccreator.cpp https://commits.kde.org/kio-extras/c734c5d5a1b47f749ef9230454f963b3b7daf573 |