| Summary: | Needs some more spacing on the sides | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Albert Astals Cid <aacid> |
| Component: | Digital Clock | Assignee: | Martin Klapetek <mklapetek> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kde |
| Priority: | NOR | ||
| Version: | 5.1.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/plasma-desktop/570732bf7a8c56c88614f3be15ad5d3341fa86a0 | Version Fixed In: | |
| Attachments: | Screenshot | ||
Interesting. When the panel is not maximized, there is almost enough padding so it does not look as bad. I wonder if maximized panels should have some inner padding at the sides... Will try to fix it from the clock applet. Git commit 2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f by Marco Martin. Committed on 17/11/2014 at 17:06. Pushed by mart into branch 'master'. set thr right margin too M +1 -1 desktoppackage/contents/views/Panel.qml http://commits.kde.org/plasma-desktop/2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f Marco can we get that backported to Plasma 5.1 branch?
Also not an expert at all of the code myself but it feels a bit weird using
root.fixedMargins.bottom for anchors.rightMargin
Cheers,
Albert
El Dilluns, 17 de novembre de 2014, a les 16:08:27, Marco Martin va escriure:
> https://bugs.kde.org/show_bug.cgi?id=341008
>
> Marco Martin <notmart@gmail.com> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Resolution|--- |FIXED
> Status|CONFIRMED |RESOLVED
> Latest Commit| |http://commits.kde.org/plas
> | |ma-desktop/2dc1e6d6a7397067
> | |d13905dd14ea1b2bbc40b32f
>
> --- Comment #2 from Marco Martin <notmart@gmail.com> ---
> Git commit 2dc1e6d6a7397067d13905dd14ea1b2bbc40b32f by Marco Martin.
> Committed on 17/11/2014 at 17:06.
> Pushed by mart into branch 'master'.
>
> set thr right margin too
>
> M +1 -1 desktoppackage/contents/views/Panel.qml
>
> http://commits.kde.org/plasma-desktop/2dc1e6d6a7397067d13905dd14ea1b2bbc40b3
> 2f
Git commit 679a4dcd1a3ca6fade91adf7507e1a4d5458eabd by Martin Klapetek. Committed on 20/11/2014 at 11:46. Pushed by mklapetek into branch 'master'. [desktop/views] Right margins should be counted using fixedMargins.right not .bottom M +1 -1 desktoppackage/contents/views/Panel.qml http://commits.kde.org/plasma-desktop/679a4dcd1a3ca6fade91adf7507e1a4d5458eabd Git commit 570732bf7a8c56c88614f3be15ad5d3341fa86a0 by Martin Klapetek. Committed on 20/11/2014 at 11:51. Pushed by mklapetek into branch 'Plasma/5.1'. [desktop/views] Set right margin properly This was setting the left margin twice, probably a typo. M +1 -1 desktoppackage/contents/views/Panel.qml http://commits.kde.org/plasma-desktop/570732bf7a8c56c88614f3be15ad5d3341fa86a0 |
Created attachment 89605 [details] Screenshot See the attached screenshot, the clock feels a bit too much close to the border. Maybe it's just one pixel more i'd need.