Summary: | xterm window icon is not drawn correctly | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | John Lindgren <john> |
Component: | decorations | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | john.ettedgui, scarpino |
Priority: | NOR | Flags: | thomas.luebking:
ReviewRequest+
|
Version: | 5.1.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
URL: | https://git.reviewboard.kde.org/r/121158/ | ||
Latest Commit: | http://commits.kde.org/kwindowsystem/34c49b24920274455f2784b2ae6ac9108b226856 | Version Fixed In: | |
Attachments: |
KDE screenshot
XFCE screenshot |
Description
John Lindgren
2014-10-26 00:44:11 UTC
Created attachment 89325 [details]
KDE screenshot
Created attachment 89326 [details]
XFCE screenshot
might also be a bug in kwindowsystem. probably kwindowsystem John, it would be great if you could try whether the patch fixes it for you as well. The patch works for me. Git commit 34c49b24920274455f2784b2ae6ac9108b226856 by Thomas Lübking. Committed on 17/11/2014 at 19:09. Pushed by luebking into branch 'master'. simplify format selection, make 24bit rgb32 an image w/o alphachannel is certainly not premultiplied the findFormat() made not much sense at all it was only used if the image depth was the default depth and then looked up supported 16, 24 and 32 bit formats However 32 bit images were handled before unconditionally so this was only relevant for 16 bit images (where we supported either 5-6-5 or nothing) or 24bit images, where a false value (ARGB_premultiplied implies 32bit) was returned. IOW: for the majority of images (32bit) this was not used, for 24bpp displays we got a falsely colored images and for 16bpp either a correctly colored (for 5-6-5 layouts) or no image at all (for 5-5-5 or [4-]4-4-4 layouts) I don't know whether 16bpp w/ 5-5-5 or 4-4-4 itw., but better show them miscolored images (and trigger a bug) than none. If there're funky 24bpp servers (other than 8-8-8) somebody shall please report a bug to us. Possible TODO: add a single call to test the server layout (channel masks) and yell an error if there's something "strange" M +8 -61 src/kxutils.cpp http://commits.kde.org/kwindowsystem/34c49b24920274455f2784b2ae6ac9108b226856 *** Bug 343501 has been marked as a duplicate of this bug. *** |