| Summary: | GROUP : Wallet icon for grouped photos is conceptually confusing | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Dmitri Popov <dmpop> |
| Component: | Albums-ItemGroup | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles |
| Priority: | NOR | ||
| Version: | 4.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | All | ||
| Latest Commit: | http://commits.kde.org/digikam/065203d1701a8a62249e52a6ac666f1c6e2f61b6 | Version Fixed In: | 4.5.0 |
| Sentry Crash Report: | |||
| Attachments: | image-stack group icon rendering | ||
|
Description
Dmitri Popov
2014-10-21 07:36:28 UTC
Well, please look in Oxygen icon set to see if you fion a better one. The reason to use Wallet icon is to improve visibility (another closed report). The previous one wasn't really visible. Gilles Caulier How about a folder icon like this one: http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Places-folder-orange-icon.html Another possibility is the emblem icon: http://www.iconarchive.com/show/oxygen-icons-by-oxygen-icons.org/Emblems-emblem-new-icon.html It's bright and visible and generic enough, so it won't be confusing. Emblem icon is to near Rating icon. Orange icon exist in Oxygen. Look into your distro like : /usr/share/icons/oxygen/32x32/places/ You must have a file named folder-orange.png Gilles Caulier Perhaps folder-tar.png Oxygen icon is more appropriate ? Gilles Caulier folder-tar.png is a good choice. This is another problem. Code need 2 icons : one indicating group not expanded (closed), and one indicating group expanded (open as all grouped items are visible on icon-view). Look code here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/itemview/itemviewimagedelegate.cpp#L531 Gilles Caulier I see. What about folder-documents.png when the group is not expanded (closed) and folder-blue.png when the group is expanded? folder-documents.png can be not blue if icons them is different than Oxygen. There are folder-open.png to replace folder-blue.png, but the difference is not too much visible with folder-documents.png with Oxygen theme. Gilles What do you think about image-stack.png (closed group) and image-stack-open.png (expanded group)? These icons have good contents but not too much visible : there is too much transparency here... We need a background for these icon to improve visibility Gilles If it's possible to add a background to the icons, then I'm all for it. :-) Otherwise, I guess the wallet icon are the only sensible solution. In any case, thank you, Gilles, for following up on this issue! Best, Dmitri We can add a background. The question is which one ? Technically, we can merge 2 icon together. A solid color ? Not too elegant. Another icon ? Which one ? Gilles Caulier I'm not a graphic designer, but I could try to make a few mockups. Created attachment 89229 [details]
image-stack group icon rendering
Also, we need to take a care about digiKam color theme used. Try a black based theme for example, and look if icon still well visible. Gilles Caulier I actually think that the icons in the attached mockup look okay. Is it possible to display numbers under the icons? The items number into the stack is already displayed over the icon. There is not too much space to place number on top/bottom/left/right corner of icon. Gilles I see. I think your mockup is good. It's much better that the current wallet-based one, anyway. Git commit 065203d1701a8a62249e52a6ac666f1c6e2f61b6 by Gilles Caulier. Committed on 21/10/2014 at 12:49. Pushed by cgilles into branch 'master'. Change icon-view group icons with Oxygen image-stack images. Add new information in group icon tool tip to indicate how many items are grouped and if group is open or closed. FIXED-IN: 4.5.0 M +17 -1 app/items/overlays/groupindicatoroverlay.cpp M +2 -2 libs/widgets/itemview/itemviewimagedelegate.cpp http://commits.kde.org/digikam/065203d1701a8a62249e52a6ac666f1c6e2f61b6 |