Bug 339530

Summary: kget-4.14.1/transfer-plugins/bittorrent/bttransfer.cpp:314: bad code ?
Product: [Applications] kget Reporter: dcb314
Component: torrentAssignee: KGet authors <kget>
Status: CONFIRMED ---    
Severity: normal CC: andrew.crouthamel
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description dcb314 2014-09-30 15:50:23 UTC
kget-4.14.1/transfer-plugins/bittorrent/bttransfer.cpp:314:47: warning: unsequenced modification and access to 'm_downloadedSize' [-Wunsequenced]

    if (m_downloadedSize != (m_downloadedSize = torrent->getStats().bytes_downloaded))

Suggest code rework.


Reproducible: Always
Comment 1 Andrew Crouthamel 2018-11-12 02:49:50 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 dcb314 2018-11-12 08:14:50 UTC
After all these years, the problem still exists. In function BTTransfer::updateTorrent
Comment 3 Andrew Crouthamel 2018-11-12 16:25:56 UTC
Thanks for the update!